cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10225) Deprecate com.cloud.utils.StringUtils
Date Wed, 31 Jan 2018 12:13:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346692#comment-16346692
] 

ASF GitHub Bot commented on CLOUDSTACK-10225:
---------------------------------------------

DaanHoogland commented on issue #2431: CLOUDSTACK-10225: Deprecate StringUtils in favor of
Apache Commons
URL: https://github.com/apache/cloudstack/pull/2431#issuecomment-361914342
 
 
   StringUtils is a perfect example. It can hide that we use StringUtil, StringUtilities and
StringUtils from
   org.springframework.util (two versions)
   org.owasp.esapi (thought we just phased them out we should use those)
   org.apache.commons.lang
   
   and pull in but not use:
   com.amazonaws.util  (from two jars)
   groovyjarjarantlr
   com.mysql.jdbc
   bsh
   org.codehaus.groovy.util (actually 
   org.eclipse.jetty.util (from two jars)
   io.netty.util.internal (as the package name show it should not be exposed)
   org.apache.poi.util
   
   In my blatantly inhumble opinion, these should all be hidden behind a single proxy class
the cherrypick functionality that is needed for the project (and makes clear which can be
removed asap)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Deprecate com.cloud.utils.StringUtils
> -------------------------------------
>
>                 Key: CLOUDSTACK-10225
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10225
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Wido den Hollander
>            Priority: Major
>
> com.cloud.utils.StringUtils contains a lot of methods which can be deprecated in favor
of Apache Commons.
> We should try to use Apache Commons where possible and reduce our code footprint.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message