cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10225) Deprecate com.cloud.utils.StringUtils
Date Wed, 31 Jan 2018 11:38:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346649#comment-16346649
] 

ASF GitHub Bot commented on CLOUDSTACK-10225:
---------------------------------------------

DaanHoogland commented on issue #2431: CLOUDSTACK-10225: Deprecate StringUtils in favor of
Apache Commons
URL: https://github.com/apache/cloudstack/pull/2431#issuecomment-361906802
 
 
   I think you are missing the point @rafaelweingartner. We may *need* to do a major upgrade
of a library (log4j/gson/bcprov) or we may need to change the entire library (slf4j and other
logging implemetations/StringUtils of several providers). your example just proves a 'simple'
upgrade and is actually making my point for me in this line: Having to change
   protected Logger logger = Logger.getLogger(getClass());
   to
   protected Logger logger = LogManager.getLogger(getClass());
   in every 'base'class is not something we want to do.
   If we create a proxy class it will always be in only one place. this is irrespective of
the discussion on static or instance var. It has to do with dealing with dependencies and
the issue predates object oriented programming all together.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Deprecate com.cloud.utils.StringUtils
> -------------------------------------
>
>                 Key: CLOUDSTACK-10225
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10225
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Wido den Hollander
>            Priority: Major
>
> com.cloud.utils.StringUtils contains a lot of methods which can be deprecated in favor
of Apache Commons.
> We should try to use Apache Commons where possible and reduce our code footprint.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message