cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10222) Clean previous snaphosts from primary storage when taking new one
Date Wed, 10 Jan 2018 09:44:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319968#comment-16319968
] 

ASF GitHub Bot commented on CLOUDSTACK-10222:
---------------------------------------------

rafaelweingartner commented on a change in pull request #2398: CLOUDSTACK-10222: Clean previous
snaphosts from primary storage when …
URL: https://github.com/apache/cloudstack/pull/2398#discussion_r160629183
 
 

 ##########
 File path: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625StorageProcessor.java
 ##########
 @@ -559,12 +559,12 @@ public Answer backupSnapshot(final CopyCommand cmd) {
                     physicalSize = Long.parseLong(tmp[1]);
                     finalPath = folder + File.separator + snapshotBackupUuid + ".vhd";
                 }
-
-                final String volumeUuid = snapshotTO.getVolume().getPath();
 
 Review comment:
   This is where I was getting confused. I am inspecting the code in master, and we were only
removing other snapshots, but the last one when it was not a full clone. You changed so we
remove all but the last one always.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Clean previous snaphosts from primary storage when taking new one
> -----------------------------------------------------------------
>
>                 Key: CLOUDSTACK-10222
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10222
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Secondary Storage, Snapshot, XenServer
>    Affects Versions: 4.10.0.0
>         Environment: XenServer, Swift
>            Reporter: Khosrow Moossavi
>              Labels: easyfix
>             Fix For: 4.11.0.0
>
>
> When user creates a snapshot (manual or recurring), snapshot remains on the primary storage,
even if the snapshot is transferred successfully to secondary storage. This is causing issues
because XenServer can only hold a limited number of snapshots in its VDI chain, preventing
the user from creating new snapshots after some time, when too many old snapshots are present
on the primary storage. 
> {code:java}
> reason: SR_BACKEND_FAILURE_109 The snapshot chain is too long
> {code}
> Proposed solution:
> Keep only one snapshot (last successful) on the primary storage regardless that it was
a full or partial snapshot.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message