cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10210) remove test file
Date Thu, 04 Jan 2018 10:05:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311106#comment-16311106
] 

ASF GitHub Bot commented on CLOUDSTACK-10210:
---------------------------------------------

rafaelweingartner commented on issue #2384: CLOUDSTACK-10210 cleanup testfile
URL: https://github.com/apache/cloudstack/pull/2384#issuecomment-355243616
 
 
   @DaanHoogland first, if the other test is disabled, what about deleting it?
   
   Second, I also prefer as mark said, delete (delete, not deleteOnExit) the file right after
the assertion. If someone is creating something in the FS in one test method and lazily using
in other....well, that is something we have to change.
   
   If the file is used in more methods and only created at that one, it will be deleted anyway,
right? I have not checked the docs, but I have the impression the @Before, and @After I executed
each and respectively before and after each test method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> remove test file
> ----------------
>
>                 Key: CLOUDSTACK-10210
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10210
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Secondary Storage
>            Reporter: Daan Hoogland
>            Assignee: Daan Hoogland
>            Priority: Trivial
>
> test leaves 'testfile' as remanence. remove in @after test finishes 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message