cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10210) remove test file
Date Thu, 04 Jan 2018 09:14:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311057#comment-16311057
] 

ASF GitHub Bot commented on CLOUDSTACK-10210:
---------------------------------------------

marcaurele commented on a change in pull request #2384: CLOUDSTACK-10210 cleanup testfile
URL: https://github.com/apache/cloudstack/pull/2384#discussion_r159606283
 
 

 ##########
 File path: services/secondary-storage/server/test/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResourceTest.java
 ##########
 @@ -49,16 +51,22 @@ public void setUp() {
         resource = new NfsSecondaryStorageResource();
     }
 
+    String filename = "testfile";
+    @After
+    public void cleanup() {
+        File remnance = new File(filename);
+        remnance.deleteOnExit();
 
 Review comment:
   In case someone run in an IDE only 1 of the class tests, it will cause an error. It's best
to do the cleanup inside the test method where the file is created.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> remove test file
> ----------------
>
>                 Key: CLOUDSTACK-10210
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10210
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Secondary Storage
>            Reporter: Daan Hoogland
>            Assignee: Daan Hoogland
>            Priority: Trivial
>
> test leaves 'testfile' as remanence. remove in @after test finishes 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message