cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10207) updateVpnCustomerGateway: unexpected changes on optional keys
Date Thu, 04 Jan 2018 11:33:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311222#comment-16311222
] 

ASF GitHub Bot commented on CLOUDSTACK-10207:
---------------------------------------------

DaanHoogland commented on a change in pull request #2377: CLOUDSTACK-10207: updateVpnCustomerGateway:
fix defaulting for option…
URL: https://github.com/apache/cloudstack/pull/2377#discussion_r159630403
 
 

 ##########
 File path: server/src/com/cloud/network/vpn/Site2SiteVpnManagerImpl.java
 ##########
 @@ -426,72 +426,52 @@ public Site2SiteCustomerGateway updateCustomerGateway(UpdateVpnCustomerGatewayCm
                 }
             }
         }
-        String name = cmd.getName();
         String gatewayIp = cmd.getGatewayIp();
         if (!NetUtils.isValidIp(gatewayIp) && !NetUtils.verifyDomainName(gatewayIp))
{
             throw new InvalidParameterValueException("The customer gateway ip/Domain " +
gatewayIp + " is invalid!");
         }
-        if (name == null) {
-            name = "VPN-" + gatewayIp;
-        }
         String guestCidrList = cmd.getGuestCidrList();
         if (!NetUtils.isValidCidrList(guestCidrList)) {
             throw new InvalidParameterValueException("The customer gateway peer cidr list
" + guestCidrList + " contains an invalid cidr!");
         }
-        String ipsecPsk = cmd.getIpsecPsk();
         String ikePolicy = cmd.getIkePolicy();
-        String espPolicy = cmd.getEspPolicy();
         if (!NetUtils.isValidS2SVpnPolicy("ike", ikePolicy)) {
-            throw new InvalidParameterValueException("The customer gateway IKE policy" +
ikePolicy + " is invalid!  Verify the required Diffie Hellman (DH) group is specified.");
+            throw new InvalidParameterValueException("The customer gateway IKE policy" +
ikePolicy + " is invalid! Verify if the required Diffie Hellman (DH) group is specified.");
 
 Review comment:
   can we make this text slightly different then the one above so it will be easier to search
when one of them occur? How about adding a reason/context of the use of the invalid policy?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> updateVpnCustomerGateway: unexpected changes on optional keys
> -------------------------------------------------------------
>
>                 Key: CLOUDSTACK-10207
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10207
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: API
>            Reporter: René Moser
>            Assignee: René Moser
>            Priority: Minor
>             Fix For: 4.11.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message