cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10146) Bypass Secondary Storage for KVM templates
Date Thu, 04 Jan 2018 07:51:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310921#comment-16310921
] 

ASF GitHub Bot commented on CLOUDSTACK-10146:
---------------------------------------------

marcaurele commented on a change in pull request #2379: CLOUDSTACK-10146: Bypass Secondary
Storage for KVM templates
URL: https://github.com/apache/cloudstack/pull/2379#discussion_r159594766
 
 

 ##########
 File path: engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/TemplateInfo.java
 ##########
 @@ -25,4 +25,6 @@
     String getUniqueName();
 
     String getInstallPath();
+
+    boolean isDirectDownload();
 
 Review comment:
   Just for your info, be aware of not mixing `Boolean` and `boolean` types since the JVM
won't check for those kind of mismatch as it does auto casting to the expected type. But you
will end up with a NPE when getting a `Boolean` NULL on a method expecting a `boolean`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Bypass Secondary Storage for KVM templates
> ------------------------------------------
>
>                 Key: CLOUDSTACK-10146
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10146
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.11.0.0
>            Reporter: Nicolas Vazquez
>            Assignee: Nicolas Vazquez
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message