cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password
Date Wed, 10 Jan 2018 09:51:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16319974#comment-16319974
] 

ASF GitHub Bot commented on CLOUDSTACK-9813:
--------------------------------------------

DaanHoogland commented on a change in pull request #2097: [4.11] CLOUDSTACK-9813: Extending
Config Drive support
URL: https://github.com/apache/cloudstack/pull/2097#discussion_r160630824
 
 

 ##########
 File path: server/src/com/cloud/network/NetworkServiceImpl.java
 ##########
 @@ -4198,20 +4201,36 @@ private PhysicalNetworkServiceProvider addDefaultBaremetalProvidersToPhysicalNet
             addProviderToPhysicalNetwork(physicalNetworkId, "BaremetalUserdataProvider",
null, null);
         } else if (dvo.getNetworkType() == NetworkType.Advanced) {
             addProviderToPhysicalNetwork(physicalNetworkId, "BaremetalPxeProvider", null,
null);
-            enableBaremetalProvider("BaremetalPxeProvider");
+            enableProvider("BaremetalPxeProvider");
         }
 
         return null;
     }
 
-    private void enableBaremetalProvider(String providerName) {
+    private void enableProvider(String providerName) {
         QueryBuilder<PhysicalNetworkServiceProviderVO> q = QueryBuilder.create(PhysicalNetworkServiceProviderVO.class);
         q.and(q.entity().getProviderName(), SearchCriteria.Op.EQ, providerName);
         PhysicalNetworkServiceProviderVO provider = q.find();
         provider.setState(PhysicalNetworkServiceProvider.State.Enabled);
         _pNSPDao.update(provider.getId(), provider);
     }
 
+    private PhysicalNetworkServiceProvider addConfigDriveToPhysicalNetwork(long physicalNetworkId)
{
+        PhysicalNetworkVO pvo = _physicalNetworkDao.findById(physicalNetworkId);
+        DataCenterVO dvo = _dcDao.findById(pvo.getDataCenterId());
+        if (dvo.getNetworkType() == NetworkType.Advanced) {
 
 Review comment:
   @krissterckx leave it in, for @wido to remove hen he has test-time.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Use configdrive for userdata, metadata & password 
> --------------------------------------------------
>
>                 Key: CLOUDSTACK-9813
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9813
>             Project: CloudStack
>          Issue Type: New Feature
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: KVM, Network Controller, Secondary Storage, SystemVM, VMware
>    Affects Versions: Future
>            Reporter: Eric Waegeman
>            Assignee: Kris Sterckx
>
> To avoid the use of an extra VM for the virtual router we implement configdrive for userdata,
metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware plugins
are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message