cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CLOUDSTACK-9813) Use configdrive for userdata, metadata & password
Date Tue, 09 Jan 2018 14:54:01 GMT


ASF GitHub Bot commented on CLOUDSTACK-9813:

krissterckx commented on a change in pull request #2097: [4.11] CLOUDSTACK-9813: Extending
Config Drive support

 File path: server/src/com/cloud/network/
 @@ -4198,20 +4201,36 @@ private PhysicalNetworkServiceProvider addDefaultBaremetalProvidersToPhysicalNet
             addProviderToPhysicalNetwork(physicalNetworkId, "BaremetalUserdataProvider",
null, null);
         } else if (dvo.getNetworkType() == NetworkType.Advanced) {
             addProviderToPhysicalNetwork(physicalNetworkId, "BaremetalPxeProvider", null,
-            enableBaremetalProvider("BaremetalPxeProvider");
+            enableProvider("BaremetalPxeProvider");
         return null;
-    private void enableBaremetalProvider(String providerName) {
+    private void enableProvider(String providerName) {
         QueryBuilder<PhysicalNetworkServiceProviderVO> q = QueryBuilder.create(PhysicalNetworkServiceProviderVO.class);
         q.and(q.entity().getProviderName(), SearchCriteria.Op.EQ, providerName);
         PhysicalNetworkServiceProviderVO provider = q.find();
         _pNSPDao.update(provider.getId(), provider);
+    private PhysicalNetworkServiceProvider addConfigDriveToPhysicalNetwork(long physicalNetworkId)
+        PhysicalNetworkVO pvo = _physicalNetworkDao.findById(physicalNetworkId);
+        DataCenterVO dvo = _dcDao.findById(pvo.getDataCenterId());
+        if (dvo.getNetworkType() == NetworkType.Advanced) {
 Review comment:
   No technical reason but there is very limited knowledge about Basic networking within Nuage
team; it would be best that other community members further extend it. We could leave out
the check but it might not just work like that.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Use configdrive for userdata, metadata & password 
> --------------------------------------------------
>                 Key: CLOUDSTACK-9813
>                 URL:
>             Project: CloudStack
>          Issue Type: New Feature
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: KVM, Network Controller, Secondary Storage, SystemVM, VMware
>    Affects Versions: Future
>            Reporter: Eric Waegeman
>            Assignee: Kris Sterckx
> To avoid the use of an extra VM for the virtual router we implement configdrive for userdata,
metadata & password. 
> The configdrive ISO is created on the secondary store and the KVM & VMware plugins
are adapted to accept the configdrive ISO as second cdrom.
> Is applicable for isolated, VPC and shared networks.

This message was sent by Atlassian JIRA

View raw message