cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9620) Improvements for Managed Storage
Date Thu, 04 Jan 2018 01:24:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310562#comment-16310562
] 

ASF GitHub Bot commented on CLOUDSTACK-9620:
--------------------------------------------

mike-tutkowski commented on a change in pull request #2298: CLOUDSTACK-9620: Enhancements
for managed storage
URL: https://github.com/apache/cloudstack/pull/2298#discussion_r159563869
 
 

 ##########
 File path: core/src/com/cloud/agent/api/StartAnswer.java
 ##########
 @@ -24,9 +24,12 @@
 import com.cloud.agent.api.to.VirtualMachineTO;
 
 public class StartAnswer extends Answer {
+    public static final String PATH = "path";
+    public static final String IMAGE_FORMAT = "imageFormat";
+
     VirtualMachineTO vm;
     String hostGuid;
-    Map<String, String> _iqnToPath;
+    private Map<String, Map<String, String>> _iqnToData;
 
 Review comment:
   With regards to multiple PRs: Originally I had it that way (VMware in one PR, KVM in another,
and XenServer in a third). Unfortunately, since 4.10 took a very long to come out, it became
a big pain to constantly rebase and maintain all of those PRs. As such, I merged the code
into this one to simplify PR maintenance and to minimize the chances of making mistakes with
rebasing due to having to perform that action so many times (and having to make so many manual
merge fixes along the way). At this point, I think it's safest to stay with this one, large
PR.
   
   Feel free to provide your code style and maintainability suggestions. I'm happy to hear
what you have to say.
     

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Improvements for Managed Storage
> --------------------------------
>
>                 Key: CLOUDSTACK-9620
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9620
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: KVM, Management Server, VMware, XenServer
>    Affects Versions: 4.11.0.0
>         Environment: KVM, vSphere, and XenServer
>            Reporter: Mike Tutkowski
>            Assignee: Mike Tutkowski
>             Fix For: 4.11.0.0
>
>
> Allowed zone-wide primary storage based on a custom plug-in to be added via the GUI in
a KVM-only environment (previously this only worked for XenServer and VMware)
> Added support for root disks on managed storage with KVM
> Added support for volume snapshots with managed storage on KVM
> Enable creating a template directly from a volume (i.e. without having to go through
a volume snapshot) on KVM with managed storage
> Only allow the resizing of a volume for managed storage on KVM if the volume in question
is either not attached to a VM or is attached to a VM in the Stopped state.
> Included support for Reinstall VM on KVM with managed storage
> Enabled offline migration on KVM from non-managed storage to managed storage and vice
versa
> Included support for online storage migration on KVM with managed storage (NFS and Ceph
to managed storage)
> Added support to download (extract) a managed-storage volume to a QCOW2 file
> When uploading a file from outside of CloudStack to CloudStack, set the min and max IOPS,
if applicable.
> Included support for the KVM auto-convergence feature
> The compression flag was actually added in version 1.0.3 (1000003) as opposed to version
1.3.0 (1003000) (changed this to reflect the correct version)
> On KVM when using iSCSI-based managed storage, if the user shuts a VM down from the guest
OS (as opposed to doing so from CloudStack), we need to pass to the KVM agent a list of applicable
iSCSI volumes that need to be disconnected.
> Added a new Global Setting: kvm.storage.live.migration.wait
> For XenServer, added a check to enforce that only volumes from zone-wide managed storage
can be storage motioned from a host in one cluster to a host in another cluster (cannot do
so at the time being with volumes from cluster-scoped managed storage)
> Don’t allow Storage XenMotion on a VM that has any managed-storage volume with one
or more snapshots.
> Enabled for managed storage with VMware: Template caching, create snapshot, delete snapshot,
create volume from snapshot, and create template from snapshot
> Added an SIOC API plug-in to support VMware SIOC
> When starting a VM that uses managed storage in a cluster other than the one it last
was running in, we need to remove the reference to the iSCSI volume from the original cluster.
> Added the ability to revert a volume to a snapshot
> Enable cluster-scoped managed storage
> Add support for VMware dynamic discovery



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message