Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Wed, 6 Dec 2017 16:10:02 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.13123216.1512573661000.399580.1512576602568@Atlassian.JIRA>
In-Reply-To: <JIRA.13123216.1512573661000@Atlassian.JIRA>
References: <JIRA.13123216.1512573661000@Atlassian.JIRA> <JIRA.13123216.1512573661544@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CLOUDSTACK-10177) NPE when programming Security
 Groups with KVM
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Wed, 06 Dec 2017 16:10:09 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10177?page=3Dcom.atl=
assian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D16280393#comment-16280393 ]=20

ASF GitHub Bot commented on CLOUDSTACK-10177:
---------------------------------------------

bwsw commented on issue #2355: CLOUDSTACK-10177: Only pass IPv6 address to =
Security Group Python scr=E2=80=A6
URL: https://github.com/apache/cloudstack/pull/2355#issuecomment-349687296
=20
=20
   @GabrielBrascher @wido=20
   Also, this fix already present in previous PRs in broader edition, becau=
se I cherry picked it to #2320 from somewhere. Also, please take a look at =
security_groups.py because there are still cases when ICMPv6 can lead to ex=
ceptions without proper handling. E.g. passing -1,-1 for icmp v6 SG.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
=20
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> NPE when programming Security Groups with KVM
> ---------------------------------------------
>
>                 Key: CLOUDSTACK-10177
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-101=
77
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the defa=
ult.)=20
>          Components: KVM
>    Affects Versions: 4.10.0.0
>         Environment: Ubuntu 16.04 - KVM=20
>            Reporter: Wido den Hollander
>              Labels: ipv6, kvm, security-groups
>
> On a Hypervisor we saw the programming of Security Groups fail and I am n=
ot sure yet why:
> {quote}2017-12-06 14:10:31,095 DEBUG [cloud.agent.Agent] (agentRequest-Ha=
ndler-15:null) (logid:e68a57b9) Request:Seq 1-3318027025465216281:  { Cmd ,=
 MgmtId: 90520741056852, via: 1, Ver: v1, Flags: 100111, [{"com.cloud.agent=
.api.SecurityGroupRulesCmd":{"guestIp":"62.221.192.7","vmName":"i-
> 4-6-VM","guestMac":"1e:00:4f:00:00:f9","signature":"4134ed9a39aa2aa856207=
80ce4b7bc27","seqNum":14,"vmId":6,"msId":90520741056852,"ingressRuleSet":[{=
"proto":"tcp","startPort":22,"endPort":22}],"egressRuleSet":[],"wait":0}}] =
}
> 2017-12-06 14:10:31,095 DEBUG [cloud.agent.Agent] (agentRequest-Handler-1=
5:null) (logid:e68a57b9) Processing command: com.cloud.agent.api.SecurityGr=
oupRulesCmd
> 2017-12-06 14:10:31,095 DEBUG [kvm.resource.LibvirtConnection] (agentRequ=
est-Handler-15:null) (logid:e68a57b9) Looking for libvirtd connection at: q=
emu:///system
> 2017-12-06 14:10:31,098 DEBUG [kvm.resource.LibvirtComputingResource] (ag=
entRequest-Handler-15:null) (logid:e68a57b9) Executing: /usr/share/cloudsta=
ck-common/scripts/vm/network/security_group.py add_network_rules --vmname i=
-4-6-VM --vmid 6 --vmip 62.221.192.7 --vmip6 null --sig 413
> 4ed9a39aa2aa85620780ce4b7bc27 --seq 14 --vmmac 1e:00:4f:00:00:f9 --vif vn=
et6 --brname cloudbr0 --nicsecips 0: --rules I:tcp:22:22:0.0.0.0/0,NEXT;=20
> 2017-12-06 14:10:31,098 WARN  [kvm.resource.LibvirtComputingResource] (ag=
entRequest-Handler-15:null) (logid:e68a57b9) Exception: /usr/share/cloudsta=
ck-common/scripts/vm/network/security_group.py add_network_rules --vmname i=
-4-6-VM --vmid 6 --vmip 62.221.192.7 --vmip6 null --sig 4134ed9a39aa2aa8562=
0780ce4b7bc27 --seq 14 --vmmac 1e:00:4f:00:00:f9 --vif vnet6 --brname cloud=
br0 --nicsecips 0: --rules I:tcp:22:22:0.0.0.0/0,NEXT;=20
> java.lang.NullPointerException
>         at java.lang.ProcessBuilder.start(ProcessBuilder.java:1012)
>         at com.cloud.utils.script.Script.execute(Script.java:214)
>         at com.cloud.utils.script.Script.execute(Script.java:182)
>         at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.add=
NetworkRules(LibvirtComputingResource.java:3429)
>         at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtSecurityGroup=
RulesCommandWrapper.execute(LibvirtSecurityGroupRulesCommandWrapper.java:57=
)
>         at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtSecurityGroup=
RulesCommandWrapper.execute(LibvirtSecurityGroupRulesCommandWrapper.java:36=
)
>         at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtRequestWrappe=
r.execute(LibvirtRequestWrapper.java:75)
>         at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.exe=
cuteRequest(LibvirtComputingResource.java:1369)
>         at com.cloud.agent.Agent.processRequest(Agent.java:525)
>         at com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:83=
3)
>         at com.cloud.utils.nio.Task.call(Task.java:83)
>         at com.cloud.utils.nio.Task.call(Task.java:29)
>         at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolEx=
ecutor.java:1149)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolE=
xecutor.java:624)
>         at java.lang.Thread.run(Thread.java:748)
> 2017-12-06 14:10:31,098 WARN  [resource.wrapper.LibvirtSecurityGroupRules=
CommandWrapper] (agentRequest-Handler-15:null) (logid:e68a57b9) Failed to p=
rogram network rules for vm i-4-6-VM
> 2017-12-06 14:10:31,098 DEBUG [cloud.agent.Agent] (agentRequest-Handler-1=
5:null) (logid:e68a57b9) Seq 1-3318027025465216281:  { Ans: , MgmtId: 90520=
741056852, via: 1, Ver: v1, Flags: 110, [{"com.cloud.agent.api.SecurityGrou=
pRuleAnswer":{"logSequenceNumber":14,"vmId":6,"reason":"PROGRAMMING_FAILED"=
,"result":false,"details":"programming network rules failed","wait":0}}] }
> {quote}
> I see the vmip6 being null and after setting a IPv6 address for the Insta=
nce it suddenly worked.
> However, I was not yet able in the code to figure out why this is a NPE i=
n com.cloud.utils.Script
> It has a issue with getting back output from ProcessBuilder.
> Creating this ticket to make sure it's tracked, but I don't know what is =
happening yet.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)