Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 28725200D5A for ; Thu, 14 Dec 2017 11:15:07 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 26D8C160C04; Thu, 14 Dec 2017 10:15:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6C4E0160C01 for ; Thu, 14 Dec 2017 11:15:06 +0100 (CET) Received: (qmail 77557 invoked by uid 500); 14 Dec 2017 10:15:05 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 77548 invoked by uid 500); 14 Dec 2017 10:15:05 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 77545 invoked by uid 99); 14 Dec 2017 10:15:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Dec 2017 10:15:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 355E91809DC for ; Thu, 14 Dec 2017 10:15:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 0EtARx1-iwDT for ; Thu, 14 Dec 2017 10:15:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 13A3B5F397 for ; Thu, 14 Dec 2017 10:15:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 065DAE25C2 for ; Thu, 14 Dec 2017 10:15:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6F18721305 for ; Thu, 14 Dec 2017 10:15:01 +0000 (UTC) Date: Thu, 14 Dec 2017 10:15:01 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-10176) VM Start Api Job returns success for failed Job MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 14 Dec 2017 10:15:07 -0000 [ https://issues.apache.org/jira/browse/CLOUDSTACK-10176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16290662#comment-16290662 ] ASF GitHub Bot commented on CLOUDSTACK-10176: --------------------------------------------- niteshsarda commented on a change in pull request #2354: CLOUDSTACK-10176:VM Start Api Job returns success for failed Job URL: https://github.com/apache/cloudstack/pull/2354#discussion_r156902284 ########## File path: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java ########## @@ -4731,7 +4732,8 @@ protected VirtualMachine retrieve() { } catch (CloudRuntimeException e){ s_logger.info("Caught CloudRuntimeException, returning job failed"); Review comment: @rhtyd : Changed code as per suggestion. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > VM Start Api Job returns success for failed Job > ----------------------------------------------- > > Key: CLOUDSTACK-10176 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10176 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Reporter: Nitesh Sarda > > *ISSUE :* > VM start API Job returns success for failed Job > *STEPS TO REPRODUCE :* > # Stop VM instance. > # Mark state of associate router as Stopping from DB > # Execute startVirtualMachine Api from rest client. > # VM will not start but still main job will return the status as SUCCEEDED, whereas sub-job for command VmWorkStart will return status as failed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)