Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Sun, 24 Dec 2017 09:54:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12671301.1380519392000.527110.1514109240232@Atlassian.JIRA>
In-Reply-To: <JIRA.12671301.1380519392000@Atlassian.JIRA>
References: <JIRA.12671301.1380519392000@Atlassian.JIRA> <JIRA.12671301.1380519392049@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CLOUDSTACK-4757) Support OVA files with
 multiple disks for templates
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sun, 24 Dec 2017 09:54:09 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302797#comment-16302797 ] 

ASF GitHub Bot commented on CLOUDSTACK-4757:
--------------------------------------------

rafaelweingartner commented on a change in pull request #2146: CLOUDSTACK-4757: Support OVA files with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#discussion_r158598357
 
 
 ##########
 File path: api/src/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
 ##########
 @@ -443,6 +449,37 @@ public String getKeyboard() {
         return dhcpOptionsMap;
     }
 
+    public Map<Long, DiskOffering> getDataDiskTemplateToDiskOfferingMap() {
+        if (diskOfferingId != null && dataDiskTemplateToDiskOfferingList != null) {
 
 Review comment:
   Great. Then, what about changing things a little bit to reduce the number of lines inside an IF statement?
   
   You could do `if(CollectionUtils.isEmpty(dataDiskTemplateToDiskOfferingList )){return new HashMap<Long, DiskOffering>()}`
   
   Then, you would not need the `if` statement at line 457. This reduces one level of cyclomatic complexity in this method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Support OVA files with multiple disks for templates
> ---------------------------------------------------
>
>                 Key: CLOUDSTACK-4757
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
>             Project: CloudStack
>          Issue Type: New Feature
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Storage Controller
>            Reporter: Likitha Shetty
>            Assignee: Nicolas Vazquez
>            Priority: Minor
>             Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of XenServer/XCP and KVM hypervisors since the files used for templates and volumes are virtual disks (VHD, QCOW2). However, VMware volumes and templates are in OVA format, which are archives that can contain a complete VM including multiple VMDKs and other files such as ISOs. And currently, Cloudstack only supports Template creation based on OVA files containing a single disk. If a user creates a template from a OVA file containing more than 1 disk and launches an instance using this template, only the first disk is attached to the new instance and other disks are ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains multiple disks to a VM will result in only one VMDK to being attached to the VM.
> This behavior needs to be improved in VMWare to support OVA files with multiple disks for both uploaded volumes and templates. i.e. If a user creates a template from a OVA file containing more than 1 disk and launches an instance using this template, the first disk should be attached to the new instance as the ROOT disk and volumes should be created based on other VMDK disks in the OVA file and should be attached to the instance.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)