cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10197) XenServer 7.1: Cannot mount xentool iso from cloudstack on VMs
Date Fri, 22 Dec 2017 22:09:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302002#comment-16302002
] 

ASF GitHub Bot commented on CLOUDSTACK-10197:
---------------------------------------------

rafaelweingartner commented on a change in pull request #2365: CLOUDSTACK-10197: Rename xentools
iso for XenServer 7.0+
URL: https://github.com/apache/cloudstack/pull/2365#discussion_r158563727
 
 

 ##########
 File path: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/discoverer/XcpServerDiscoverer.java
 ##########
 @@ -529,13 +540,12 @@ public boolean processCommands(long agentId, long seq, Command[] commands)
{
     }
 
     private void createXsToolsISO() {
-        String isoName = "xs-tools.iso";
-        VMTemplateVO tmplt = _tmpltDao.findByTemplateName(isoName);
+        VMTemplateVO tmplt = _tmpltDao.findByTemplateName(_toolsIsoName);
         Long id;
         if (tmplt == null) {
             id = _tmpltDao.getNextInSequence(Long.class, "id");
             VMTemplateVO template =
-                    VMTemplateVO.createPreHostIso(id, isoName, isoName, ImageFormat.ISO,
true, true, TemplateType.PERHOST, null, null, true, 64, Account.ACCOUNT_ID_SYSTEM,
+                    VMTemplateVO.createPreHostIso(id, _toolsIsoName, _toolsIsoName, ImageFormat.ISO,
true, true, TemplateType.PERHOST, null, null, true, 64, Account.ACCOUNT_ID_SYSTEM,
 
 Review comment:
   I do not know what you think about the use of "_" here to denote object attributes, but
I do not see any benefit on using it. As a matter of fact, I see most PRs removing them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> XenServer 7.1: Cannot mount  xentool iso from cloudstack on VMs
> ---------------------------------------------------------------
>
>                 Key: CLOUDSTACK-10197
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10197
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.10.0.0
>         Environment: XenServer 7.0+
>            Reporter: Khosrow Moossavi
>             Fix For: Future
>
>
> In XenServer 7.0+ xentools iso has been renamed from *xs-tools* to *guest-tools* so CloudStack
fails to attach it to any VM.
> {code}
> (acs-admin) > attach iso virtualmachineid=d13eeff1-2d99-46a9-8fc5-3510df6e9f5e id=e8a56540-0fc3-44de-9911-635d2d8f25c4
> errorcode = 530
> errortext = Failed to attach iso
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message