cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10176) VM Start Api Job returns success for failed Job
Date Fri, 08 Dec 2017 10:46:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283351#comment-16283351
] 

ASF GitHub Bot commented on CLOUDSTACK-10176:
---------------------------------------------

rhtyd commented on a change in pull request #2354: CLOUDSTACK-10176:VM Start Api Job returns
success for failed Job
URL: https://github.com/apache/cloudstack/pull/2354#discussion_r155749424
 
 

 ##########
 File path: engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java
 ##########
 @@ -4731,7 +4732,8 @@ protected VirtualMachine retrieve() {
         }
         catch (CloudRuntimeException e){
             s_logger.info("Caught CloudRuntimeException, returning job failed");
-            return new Pair<JobInfo.Status, String>(JobInfo.Status.FAILED, null);
+            CloudRuntimeException ex = new CloudRuntimeException("Unable to start VM instance
: " + e);
+            return new Pair<JobInfo.Status, String>(JobInfo.Status.FAILED, JobSerializerHelper.toObjectSerializedString(ex));
 
 Review comment:
   Why not return `e` instead of creating a new `ex`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> VM Start Api Job returns success for failed Job
> -----------------------------------------------
>
>                 Key: CLOUDSTACK-10176
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10176
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Nitesh Sarda
>
> *ISSUE :*
> VM start API Job returns success for failed Job
> *STEPS TO REPRODUCE :*
> #  Stop VM instance.
> # Mark state of associate router as Stopping from DB
> # Execute startVirtualMachine Api from rest client.
> # VM will not start but still main job will return the status as SUCCEEDED, whereas sub-job
for command VmWorkStart will return status as failed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message