cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10175) Listing VPCs with a domain account and project id -1 returns all the VPCs in the syste
Date Wed, 06 Dec 2017 21:41:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280969#comment-16280969
] 

ASF GitHub Bot commented on CLOUDSTACK-10175:
---------------------------------------------

rafaelweingartner commented on a change in pull request #2352: CLOUDSTACK-10175: prevent VPC
list leakage
URL: https://github.com/apache/cloudstack/pull/2352#discussion_r155369392
 
 

 ##########
 File path: server/src/com/cloud/user/AccountManagerImpl.java
 ##########
 @@ -2472,6 +2464,11 @@ public void buildACLSearchParameters(Account caller, Long id, String
accountName
                 if (projectId.longValue() == -1) {
                     if (caller.getType() == Account.ACCOUNT_TYPE_NORMAL) {
                         permittedAccounts.addAll(_projectMgr.listPermittedProjectAccounts(caller.getId()));
+
+                        //permittedAccounts can be empty when the caller is not a part of
any project (a domain account)
+                        if (permittedAccounts.isEmpty()) {
 
 Review comment:
   thanks!
   So, it seems that the code was not formatted properly before.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Listing VPCs with a domain account and project id -1 returns all the VPCs in the syste
> --------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-10175
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10175
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.10.0.0
>            Reporter: Khosrow Moossavi
>             Fix For: Future
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message