cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10126) Separate Subnet for CPVM and SSVM
Date Sat, 23 Dec 2017 20:34:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302578#comment-16302578
] 

ASF GitHub Bot commented on CLOUDSTACK-10126:
---------------------------------------------

nitin-maharana commented on a change in pull request #2368: CLOUDSTACK-10126: Separate Subnet
for SSVM and CPVM
URL: https://github.com/apache/cloudstack/pull/2368#discussion_r158588796
 
 

 ##########
 File path: engine/schema/src/com/cloud/dc/dao/DataCenterIpAddressDaoImpl.java
 ##########
 @@ -47,16 +49,26 @@
     private final GenericSearchBuilder<DataCenterIpAddressVO, Integer> AllAllocatedIpCount;
     private final GenericSearchBuilder<DataCenterIpAddressVO, Integer> AllAllocatedIpCountForDc;
 
+    private static final ConfigKey<Boolean> SystemVmManagementIpReservationModeStrictness
= new ConfigKey<Boolean>("Advanced",
+            Boolean.class, "system.vm.management.ip.reservation.mode.strictness", "false","If
enabled, the use of System VMs management IP reservation is strict, preferred if not.", false,
ConfigKey.Scope.Global);
+
     @Override
     @DB
-    public DataCenterIpAddressVO takeIpAddress(long dcId, long podId, long instanceId, String
reservationId) {
+    public DataCenterIpAddressVO takeIpAddress(long dcId, long podId, long instanceId, String
reservationId, boolean forSystemVms) {
         SearchCriteria<DataCenterIpAddressVO> sc = AllFieldsSearch.create();
         sc.setParameters("pod", podId);
         sc.setParameters("taken", (Date)null);
+        sc.setParameters("forSystemVms", forSystemVms);
 
         TransactionLegacy txn = TransactionLegacy.currentTxn();
         txn.start();
         DataCenterIpAddressVO vo = lockOneRandomRow(sc, true);
+
+        // If there is no explicitly created range for system vms
 
 Review comment:
   Would be better if you add the reservation mode is preferred in the comment section as
well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Separate Subnet for CPVM and SSVM
> ---------------------------------
>
>                 Key: CLOUDSTACK-10126
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10126
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.11.0.0
>            Reporter: Nicolas Vazquez
>            Assignee: Nicolas Vazquez
>
> Separate Management Subnet for CPVM and SSVM



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message