cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10108) ConfigKey based approach for reading 'ping' configuaration for Management Server
Date Tue, 26 Dec 2017 06:34:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303523#comment-16303523
] 

ASF GitHub Bot commented on CLOUDSTACK-10108:
---------------------------------------------

rhtyd commented on a change in pull request #2292: CLOUDSTACK-10108:ConfigKey based approach
for reading 'ping' configua…
URL: https://github.com/apache/cloudstack/pull/2292#discussion_r158672111
 
 

 ##########
 File path: engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java
 ##########
 @@ -242,11 +239,11 @@ public boolean configure(final String name, final Map<String, Object>
params) th
     }
 
     protected int getPingInterval() {
-        return PingInterval.value();
+        return ManagementServiceConfiguration.PingInterval.value();
     }
 
     protected long getTimeout() {
 
 Review comment:
   Since you've introduced a new `ManagementServiceConfiguration`, why not refactor/move this
method to the class and make it reusable across server/codebase.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> ConfigKey based approach for reading 'ping' configuaration for Management Server
> --------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-10108
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10108
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: mrunalini
>            Priority: Minor
>
> In CLOUDSTACK-9886, we are reading ping.interval and ping.timeout using configdao which
involves direct reading of DB. So, replace it with ConfigKey based approach



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message