cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10108) ConfigKey based approach for reading 'ping' configuaration for Management Server
Date Thu, 21 Dec 2017 12:45:05 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299960#comment-16299960
] 

ASF GitHub Bot commented on CLOUDSTACK-10108:
---------------------------------------------

rafaelweingartner commented on a change in pull request #2292: CLOUDSTACK-10108:ConfigKey
based approach for reading 'ping' configua…
URL: https://github.com/apache/cloudstack/pull/2292#discussion_r158268226
 
 

 ##########
 File path: test/integration/component/test_host.py
 ##########
 @@ -197,8 +194,8 @@ def test_01_host_ha_with_nfs_storagepool_with_vm(self):
             
 
         hostToTest = listHost[0]
-        hostUpInCloudstack = wait_until(10, 10, self.checkHostUp, hostToTest.ipaddress, hostToTest.ipaddress)
-        #hostUpInCloudstack = wait_until(40, 10, self.checkHostStateInCloudstack, "Up", hostToTest.id)
+        #hostUpInCloudstack = wait_until(10, 10, self.checkHostUp, hostToTest.ipaddress,
hostToTest.ipaddress)
 
 Review comment:
   Can you delete the commented line?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> ConfigKey based approach for reading 'ping' configuaration for Management Server
> --------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-10108
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10108
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: mrunalini
>            Priority: Minor
>
> In CLOUDSTACK-9886, we are reading ping.interval and ping.timeout using configdao which
involves direct reading of DB. So, replace it with ConfigKey based approach



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message