cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10108) ConfigKey based approach for reading 'ping' configuaration for Management Server
Date Thu, 21 Dec 2017 09:29:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299754#comment-16299754
] 

ASF GitHub Bot commented on CLOUDSTACK-10108:
---------------------------------------------

rhtyd commented on a change in pull request #2292: CLOUDSTACK-10108:ConfigKey based approach
for reading 'ping' configua…
URL: https://github.com/apache/cloudstack/pull/2292#discussion_r158230085
 
 

 ##########
 File path: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java
 ##########
 @@ -79,6 +78,11 @@
 
     private static final String LIST_CLUSTERID_FOR_HOST_TAG = "select distinct cluster_id
from host join host_tags on host.id = host_tags.host_id and host_tags.tag = ?";
 
+    protected final ConfigKey<Integer> PingInterval = new ConfigKey<Integer>("Advanced",
Integer.class, "ping.interval", "60",
+            "Interval to send application level pings to make sure the connection is still
working", false);
+    protected final ConfigKey<Float> PingTimeout = new ConfigKey<Float>("Advanced",
Float.class, "ping.timeout", "2.5",
 
 Review comment:
   There seems to be multiple instances/declarations of both these ConfigKeys, can you refactor
them to a class/interface and consume using that. I see one in AgentManagerImpl and another
in VirtualMachinePowerStateSyncImpl, and you've added one more. Please refactor, thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> ConfigKey based approach for reading 'ping' configuaration for Management Server
> --------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-10108
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10108
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: mrunalini
>            Priority: Minor
>
> In CLOUDSTACK-9886, we are reading ping.interval and ping.timeout using configdao which
involves direct reading of DB. So, replace it with ConfigKey based approach



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message