cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10013) Migrate to Debian9 systemvmtemplate
Date Thu, 21 Dec 2017 06:01:10 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299606#comment-16299606
] 

ASF GitHub Bot commented on CLOUDSTACK-10013:
---------------------------------------------

marcaurele commented on a change in pull request #2211: CLOUDSTACK-10013: Migrate systemvmtemplate
to Debian9
URL: https://github.com/apache/cloudstack/pull/2211#discussion_r158202337
 
 

 ##########
 File path: systemvm/debian/opt/cloud/bin/cs/CsDhcp.py
 ##########
 @@ -80,7 +80,7 @@ def configure_server(self):
             # DNS search order
             if gn.get_dns() and device:
                 sline = "dhcp-option=tag:interface-%s-%s,6" % (device, idx)
-                dns_list = [x for x in gn.get_dns() if x is not None]
+                dns_list = [x for x in gn.get_dns() if not (not x)]
 
 Review comment:
   `not (not x))` Why a double negation?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Migrate to Debian9 systemvmtemplate
> -----------------------------------
>
>                 Key: CLOUDSTACK-10013
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10013
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Rohit Yadav
>            Assignee: Rohit Yadav
>             Fix For: Future, 4.11.0.0
>
>
> Migrate to debian9 based systemvmtemplate



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message