cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9772) Perform HEAD request to retrieve header information
Date Wed, 20 Dec 2017 12:03:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16298355#comment-16298355
] 

ASF GitHub Bot commented on CLOUDSTACK-9772:
--------------------------------------------

rhtyd commented on a change in pull request #1934: [CLOUDSTACK-9772] Template: perform a HEAD
request to check file size from a URL
URL: https://github.com/apache/cloudstack/pull/1934#discussion_r158005734
 
 

 ##########
 File path: utils/src/main/java/com/cloud/utils/UriUtils.java
 ##########
 @@ -201,40 +199,53 @@ public static String getUpdateUri(String url, boolean encrypt) {
         return details;
     }
 
+    public static void main(String[] args) {
 
 Review comment:
   Remove `main`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Perform HEAD request to retrieve header information
> ---------------------------------------------------
>
>                 Key: CLOUDSTACK-9772
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9772
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Template
>    Affects Versions: 4.2.0, 4.2.1, 4.3.0, 4.4.0, 4.5.0, 4.3.1, 4.4.1, 4.4.2, 4.4.3, 4.3.2,
4.5.1, 4.4.4, 4.5.2, 4.6.0, 4.6.1, 4.6.2, 4.7.0, 4.7.1, 4.8.0, 4.9.0, 4.8.1.1, 4.9.0.1, 4.5.2.2
>            Reporter: Marc-Aurèle Brothier
>            Assignee: Marc-Aurèle Brothier
>
> The function in UriUtils which perform a check for the template file size of an arbitrary
URL is sending a `GET` request to only retrieve the response header. A `HEAD` is the correct
way of retrieving such information from the response header.
> This was affecting the restart of a management server since all templates were retrieved
when receiving the startup command from the secondary storage sysvm.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message