cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9736) Incoherent validation and error message when you change the vm.password.length configuration parameter
Date Tue, 12 Dec 2017 11:37:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287477#comment-16287477
] 

ASF GitHub Bot commented on CLOUDSTACK-9736:
--------------------------------------------

rhtyd closed pull request #2358: CLOUDSTACK-9736 Incoherent validation and error message when
you chan…
URL: https://github.com/apache/cloudstack/pull/2358
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/server/src/com/cloud/server/ManagementServerImpl.java b/server/src/com/cloud/server/ManagementServerImpl.java
index da987ca1330..872a5020786 100644
--- a/server/src/com/cloud/server/ManagementServerImpl.java
+++ b/server/src/com/cloud/server/ManagementServerImpl.java
@@ -689,7 +689,7 @@
 public class ManagementServerImpl extends ManagerBase implements ManagementServer, Configurable
{
     public static final Logger s_logger = Logger.getLogger(ManagementServerImpl.class.getName());
 
-    static final ConfigKey<Integer> vmPasswordLength = new ConfigKey<Integer>("Advanced",
Integer.class, "vm.password.length", "10",
+    static final ConfigKey<Integer> vmPasswordLength = new ConfigKey<Integer>("Advanced",
Integer.class, "vm.password.length", "6",
                                                                                       "Specifies
the length of a randomly generated password", false);
     @Inject
     public AccountManager _accountMgr;


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Incoherent validation and error message when you change the vm.password.length configuration
parameter
> ------------------------------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9736
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9736
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Management Server
>    Affects Versions: 4.7.0, 4.8.0, 4.9.0, 4.10.0.0
>            Reporter: Milamber
>            Assignee: Milamber
>            Priority: Minor
>             Fix For: 4.10.1.0
>
>
> When you try to change the value of vm.password.length parameters, if the value is <
10 the error message says:
> "Please enter a value greater than 6 for the configuration parameter"
> In the code server/src/com/cloud/configuration/ConfigurationManagerImpl.java the validation
use 10 as length and the message says 6 for length:
>                 if ("vm.password.length".equalsIgnoreCase(name) && val < 10)
{
>                     throw new InvalidParameterValueException("Please enter a value greater
than 6 for the configuration parameter:" + name);



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message