cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-4757) Support OVA files with multiple disks for templates
Date Sat, 23 Dec 2017 12:46:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-4757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302400#comment-16302400
] 

ASF GitHub Bot commented on CLOUDSTACK-4757:
--------------------------------------------

rafaelweingartner commented on a change in pull request #2146: CLOUDSTACK-4757: Support OVA
files with multiple disks for templates
URL: https://github.com/apache/cloudstack/pull/2146#discussion_r158581871
 
 

 ##########
 File path: engine/storage/image/src/org/apache/cloudstack/storage/image/TemplateServiceImpl.java
 ##########
 @@ -1003,4 +1180,72 @@ public void addSystemVMTemplatesToSecondary(DataStore store) {
             }
         }
     }
+
+    private class CreateDataDiskTemplateContext<T> extends AsyncRpcContext<T>
{
+        private final DataObject dataDiskTemplate;
+        private final AsyncCallFuture<TemplateApiResult> future;
+
+        public CreateDataDiskTemplateContext(AsyncCompletionCallback<T> callback, DataObject
dataDiskTemplate, AsyncCallFuture<TemplateApiResult> future) {
+            super(callback);
+            this.dataDiskTemplate = dataDiskTemplate;
+            this.future = future;
+        }
+
+        public AsyncCallFuture<TemplateApiResult> getFuture() {
+            return this.future;
+        }
+    }
+
+    @Override
+    public AsyncCallFuture<TemplateApiResult> createDatadiskTemplateAsync(TemplateInfo
parentTemplate, TemplateInfo dataDiskTemplate, String path, String diskId, long fileSize,
boolean bootable) {
+        AsyncCallFuture<TemplateApiResult> future = new AsyncCallFuture<TemplateApiResult>();
+        // Make an entry for disk template in template_store_ref table
+        DataStore store = parentTemplate.getDataStore();
+        TemplateObject dataDiskTemplateOnStore;
+        if (!bootable) {
+            dataDiskTemplateOnStore = (TemplateObject)store.create(dataDiskTemplate);
+            dataDiskTemplateOnStore.processEvent(ObjectInDataStoreStateMachine.Event.CreateOnlyRequested);
+        } else {
+            dataDiskTemplateOnStore = (TemplateObject) imageFactory.getTemplate(parentTemplate,
store);
+        }
+        try {
+            CreateDataDiskTemplateContext<TemplateApiResult> context = new CreateDataDiskTemplateContext<TemplateApiResult>(null,
dataDiskTemplateOnStore, future);
+            AsyncCallbackDispatcher<TemplateServiceImpl, CreateCmdResult> caller =
AsyncCallbackDispatcher.create(this);
+            caller.setCallback(caller.getTarget().createDatadiskTemplateCallback(null, null)).setContext(context);
+            ImageStoreEntity tmpltStore = (ImageStoreEntity)parentTemplate.getDataStore();
+            tmpltStore.createDataDiskTemplateAsync(dataDiskTemplate, path, diskId, fileSize,
bootable, caller);
+        } catch (CloudRuntimeException ex) {
+            dataDiskTemplateOnStore.processEvent(ObjectInDataStoreStateMachine.Event.OperationFailed);
+            TemplateApiResult result = new TemplateApiResult(dataDiskTemplate);
+            result.setResult(ex.getMessage());
+            if (future != null) {
+                future.complete(result);
+            }
+        }
+        return future;
+    }
+
+    protected Void createDatadiskTemplateCallback(AsyncCallbackDispatcher<TemplateServiceImpl,
CreateCmdResult> callback,
+            CreateDataDiskTemplateContext<TemplateApiResult> context) {
+        if (s_logger.isDebugEnabled()) {
+            s_logger.debug("MDOVA createDatadiskTemplateCallback Performing create datadisk
template cross callback after completion");
+        }
+        DataObject dataDiskTemplate = context.dataDiskTemplate;
+        AsyncCallFuture<TemplateApiResult> future = context.getFuture();
+        CreateCmdResult result = callback.getResult();
+        TemplateApiResult dataDiskTemplateResult = new TemplateApiResult((TemplateObject)dataDiskTemplate);
+        try {
+            if (result.isSuccess()) {
+                dataDiskTemplate.processEvent(Event.OperationSuccessed, result.getAnswer());
+            } else {
+                dataDiskTemplate.processEvent(Event.OperationFailed);
+                dataDiskTemplateResult.setResult(result.getResult());
+            }
+        } catch (Exception e) {
 
 Review comment:
   Do you need to catch almost everything here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Support OVA files with multiple disks for templates
> ---------------------------------------------------
>
>                 Key: CLOUDSTACK-4757
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-4757
>             Project: CloudStack
>          Issue Type: New Feature
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Storage Controller
>            Reporter: Likitha Shetty
>            Assignee: Nicolas Vazquez
>            Priority: Minor
>             Fix For: Future
>
>
> CloudStack volumes and templates are one single virtual disk in case of XenServer/XCP
and KVM hypervisors since the files used for templates and volumes are virtual disks (VHD,
QCOW2). However, VMware volumes and templates are in OVA format, which are archives that can
contain a complete VM including multiple VMDKs and other files such as ISOs. And currently,
Cloudstack only supports Template creation based on OVA files containing a single disk. If
a user creates a template from a OVA file containing more than 1 disk and launches an instance
using this template, only the first disk is attached to the new instance and other disks are
ignored.
> Similarly with uploaded volumes, attaching an uploaded volume that contains multiple
disks to a VM will result in only one VMDK to being attached to the VM.
> This behavior needs to be improved in VMWare to support OVA files with multiple disks
for both uploaded volumes and templates. i.e. If a user creates a template from a OVA file
containing more than 1 disk and launches an instance using this template, the first disk should
be attached to the new instance as the ROOT disk and volumes should be created based on other
VMDK disks in the OVA file and should be attached to the instance.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message