Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Fri, 10 Nov 2017 13:18:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.13117518.1510302868000.206689.1510319880346@Atlassian.JIRA>
In-Reply-To: <JIRA.13117518.1510302868000@Atlassian.JIRA>
References: <JIRA.13117518.1510302868000@Atlassian.JIRA> <JIRA.13117518.1510302868241@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CLOUDSTACK-10137) Re-installation fails for
 cloudstack-management
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Fri, 10 Nov 2017 13:18:06 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10137?page=3Dcom.atl=
assian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D16247485#comment-16247485 ]=20

ASF GitHub Bot commented on CLOUDSTACK-10137:
---------------------------------------------

marcaurele commented on a change in pull request #2316: CLOUDSTACK-10137: O=
nly link log4j if not already present
URL: https://github.com/apache/cloudstack/pull/2316#discussion_r150231799
=20
=20

 ##########
 File path: debian/cloudstack-management.postinst
 ##########
 @@ -57,7 +57,9 @@ if [ "$1" =3D configure ]; then
     chgrp cloud ${CONFDIR}/${DBPROPS}
     chown -R cloud:cloud /var/log/cloudstack/management
=20
-    ln -s ${CONFDIR}/log4j-cloud.xml ${CONFDIR}/log4j.xml
+    if [ ! -e "$CONFDIR/log4j.xml" ]; then
+        ln -s ${CONFDIR}/log4j-cloud.xml ${CONFDIR}/log4j.xml
=20
 Review comment:
   Yep

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
=20
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Re-installation fails for cloudstack-management
> -----------------------------------------------
>
>                 Key: CLOUDSTACK-10137
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-101=
37
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the defa=
ult.)=20
>            Reporter: Marc-Aur=C3=A8le Brothier
>            Assignee: Marc-Aur=C3=A8le Brothier
>
> If you try to reinstall the package (using --reinstall for example) and b=
uild another version of it, the linking of {{log4j.xml}} will fail since th=
e file already exists, and let the package improperly installed.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)