Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Tue, 7 Nov 2017 15:28:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.13116572.1510024524000.170591.1510068480226@Atlassian.JIRA>
In-Reply-To: <JIRA.13116572.1510024524000@Atlassian.JIRA>
References: <JIRA.13116572.1510024524000@Atlassian.JIRA> <JIRA.13116572.1510024524265@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CLOUDSTACK-10132) Multiple Management Servers
 Support for agents
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 07 Nov 2017 15:28:05 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242182#comment-16242182 ] 

ASF GitHub Bot commented on CLOUDSTACK-10132:
---------------------------------------------

rhtyd commented on a change in pull request #2309: CLOUDSTACK-10132: Multiple Management Servers Support for agents
URL: https://github.com/apache/cloudstack/pull/2309#discussion_r149403249
 
 
 ##########
 File path: agent/src/com/cloud/agent/AgentShell.java
 ##########
 @@ -173,6 +194,19 @@ public void setPersistentProperty(String prefix, String name, String value) {
             _storage.persist(name, value);
     }
 
+    @Override
+    public boolean setPropertyAndPersist(String property, String value) {
 
 Review comment:
   Don't use it, there is another way to do that --> call setPersistentProperty, see the method is just above your implementation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Multiple Management Servers Support for agents
> ----------------------------------------------
>
>                 Key: CLOUDSTACK-10132
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10132
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.11.0.0
>            Reporter: Nicolas Vazquez
>            Assignee: Nicolas Vazquez
>
> Multiple Management Servers Support for agents


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)