Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D639C200D34 for ; Fri, 3 Nov 2017 13:00:17 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D4CAA160BE9; Fri, 3 Nov 2017 12:00:17 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 308D7160BFB for ; Fri, 3 Nov 2017 13:00:17 +0100 (CET) Received: (qmail 85123 invoked by uid 500); 3 Nov 2017 12:00:16 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 85114 invoked by uid 500); 3 Nov 2017 12:00:16 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 85111 invoked by uid 99); 3 Nov 2017 12:00:16 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Nov 2017 12:00:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D5163182831 for ; Fri, 3 Nov 2017 12:00:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Nhw9jBxOzKHg for ; Fri, 3 Nov 2017 12:00:14 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id B75C46114A for ; Fri, 3 Nov 2017 12:00:13 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 036B0E101B for ; Fri, 3 Nov 2017 12:00:13 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id A3F46241AE for ; Fri, 3 Nov 2017 12:00:12 +0000 (UTC) Date: Fri, 3 Nov 2017 12:00:12 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-10129) Show instances attached to a network/VR via navigation from VRs->instances MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 03 Nov 2017 12:00:18 -0000 [ https://issues.apache.org/jira/browse/CLOUDSTACK-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237501#comment-16237501 ] ASF GitHub Bot commented on CLOUDSTACK-10129: --------------------------------------------- nitin-maharana commented on a change in pull request #2306: CLOUDSTACK-10129: Allow navigation from VRs to network, instances, owners etc. URL: https://github.com/apache/cloudstack/pull/2306#discussion_r148764738 ########## File path: ui/scripts/system.js ########## @@ -9599,6 +9600,23 @@ }, detailView: { name: 'label.virtual.appliance.details', + viewAll: [{ + label: 'label.account', + path: 'accounts', + preFilter: function(args) { + if (args.context.routers[0].projectid) + return false; + if (args.context.routers[0].account == 'system') Review comment: Is it for System VMs? If so, then it won't appear on this page. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Show instances attached to a network/VR via navigation from VRs->instances > -------------------------------------------------------------------------- > > Key: CLOUDSTACK-10129 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10129 > Project: CloudStack > Issue Type: Bug > Security Level: Public(Anyone can view this level - this is the default.) > Reporter: Rohit Yadav > Assignee: Rohit Yadav > Fix For: 4.11.0.0 > > > Navigate to Infra->Vrs->select a VR->View instances should show instances belonging to guest network id of the VR -- This message was sent by Atlassian JIRA (v6.4.14#64029)