Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Thu, 2 Nov 2017 12:43:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.13108955.1507822955000.130921.1509626580938@Atlassian.JIRA>
In-Reply-To: <JIRA.13108955.1507822955000@Atlassian.JIRA>
References: <JIRA.13108955.1507822955000@Atlassian.JIRA> <JIRA.13108955.1507822955035@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CLOUDSTACK-10109) Enable dedication of public
 IPs to SSVM and CPVM
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 02 Nov 2017 12:43:06 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235666#comment-16235666 ] 

ASF GitHub Bot commented on CLOUDSTACK-10109:
---------------------------------------------

nitin-maharana commented on a change in pull request #2295: CLOUDSTACK-10109: Enable dedication of public IPs to SSVM and CPVM
URL: https://github.com/apache/cloudstack/pull/2295#discussion_r148519700
 
 
 ##########
 File path: server/src/com/cloud/network/guru/PublicNetworkGuru.java
 ##########
 @@ -115,7 +115,11 @@ protected PublicNetworkGuru() {
     protected void getIp(NicProfile nic, DataCenter dc, VirtualMachineProfile vm, Network network) throws InsufficientVirtualNetworkCapacityException,
         InsufficientAddressCapacityException, ConcurrentOperationException {
         if (nic.getIPv4Address() == null) {
-            PublicIp ip = _ipAddrMgr.assignPublicIpAddress(dc.getId(), null, vm.getOwner(), VlanType.VirtualNetwork, null, null, false);
+            boolean forSystemVms = false;
+            if (vm.getType().equals(VirtualMachine.Type.ConsoleProxy) || vm.getType().equals(VirtualMachine.Type.SecondaryStorageVm)) {
+                forSystemVms = true;
 
 Review comment:
   @nvazquez, I just went with the flow and found out there already exists a column name ("is_system") in user_ip_address table. Can you please see if you can make use of that instead of creating a new one ("forsystemvms").

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Enable dedication of public IPs to SSVM and CPVM
> ------------------------------------------------
>
>                 Key: CLOUDSTACK-10109
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10109
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Nicolas Vazquez
>            Assignee: Nicolas Vazquez
>            Priority: Major
>         Attachments: public01.png, public02.png, public03.png
>
>
> It is required to dedicate a public IP range for SSVM and CPVM in order to apply firewall rules to control inbound access.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)