Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0FBD5200D50 for ; Mon, 20 Nov 2017 05:09:08 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 0E1CF160C0C; Mon, 20 Nov 2017 04:09:08 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 54419160C0B for ; Mon, 20 Nov 2017 05:09:07 +0100 (CET) Received: (qmail 96689 invoked by uid 500); 20 Nov 2017 04:09:06 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 96680 invoked by uid 500); 20 Nov 2017 04:09:06 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 96677 invoked by uid 99); 20 Nov 2017 04:09:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Nov 2017 04:09:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 50FABC6724 for ; Mon, 20 Nov 2017 04:09:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.011 X-Spam-Level: X-Spam-Status: No, score=-99.011 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KB_WAM_FROM_NAME_SINGLEWORD=0.2, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id xgHiKa96LThs for ; Mon, 20 Nov 2017 04:09:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 48F5A5F3DE for ; Mon, 20 Nov 2017 04:09:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 88E3EE059C for ; Mon, 20 Nov 2017 04:09:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 32F20240D2 for ; Mon, 20 Nov 2017 04:09:00 +0000 (UTC) Date: Mon, 20 Nov 2017 04:09:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-10108) ConfigKey based approach for reading 'ping' configuaration for Management Server MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 20 Nov 2017 04:09:08 -0000 [ https://issues.apache.org/jira/browse/CLOUDSTACK-10108?page=3Dcom.atl= assian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId= =3D16258793#comment-16258793 ]=20 ASF GitHub Bot commented on CLOUDSTACK-10108: --------------------------------------------- mrunalinikankariya commented on a change in pull request #2292: CLOUDSTACK-= 10108:ConfigKey based approach for reading 'ping' configua=E2=80=A6 URL: https://github.com/apache/cloudstack/pull/2292#discussion_r151899301 =20 =20 ########## File path: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java ########## @@ -995,8 +994,8 @@ public boolean updateState(Status oldStatus, Event eve= nt, Status newStatus, Host } } if (event.equals(Event.ManagementServerDown)) { - Float pingTimeout =3D NumbersUtil.parseFloat(_configDao.getVal= ue("ping.timeout"), 2.5f); - Integer pingInterval =3D NumbersUtil.parseInt(_configDao.getVa= lue("ping.interval"), 60); + float pingTimeout =3D (Float)_configDepot.get("ping.timeout").= value(); =20 Review comment: ConfigKey for ping.timeout and ping.interval is already defined in Agent= ManagerImpl. As per my understanding ConfigDepot cached all the configurati= on parameters so i am reading from configDepot. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > ConfigKey based approach for reading 'ping' configuaration for Management= Server > -------------------------------------------------------------------------= ------- > > Key: CLOUDSTACK-10108 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-101= 08 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the defa= ult.)=20 > Reporter: mrunalini > Priority: Minor > > In CLOUDSTACK-9886, we are reading ping.interval and ping.timeout using c= onfigdao which involves direct reading of DB. So, replace it with ConfigKey= based approach -- This message was sent by Atlassian JIRA (v6.4.14#64029)