Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E17E7200D48 for ; Wed, 29 Nov 2017 09:15:09 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D7D9B160C04; Wed, 29 Nov 2017 08:15:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 29FA0160BF6 for ; Wed, 29 Nov 2017 09:15:09 +0100 (CET) Received: (qmail 1514 invoked by uid 500); 29 Nov 2017 08:15:03 -0000 Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cloudstack.apache.org Delivered-To: mailing list issues@cloudstack.apache.org Received: (qmail 1504 invoked by uid 500); 29 Nov 2017 08:15:03 -0000 Delivered-To: apmail-incubator-cloudstack-issues@incubator.apache.org Received: (qmail 1499 invoked by uid 99); 29 Nov 2017 08:15:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Nov 2017 08:15:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 234DE180715 for ; Wed, 29 Nov 2017 08:15:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 2YvsiZoRcqua for ; Wed, 29 Nov 2017 08:15:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0D7155F1A0 for ; Wed, 29 Nov 2017 08:15:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9C94DE012B for ; Wed, 29 Nov 2017 08:15:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 56D382104F for ; Wed, 29 Nov 2017 08:15:00 +0000 (UTC) Date: Wed, 29 Nov 2017 08:15:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: cloudstack-issues@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CLOUDSTACK-9772) Perform HEAD request to retrieve header information MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 29 Nov 2017 08:15:10 -0000 [ https://issues.apache.org/jira/browse/CLOUDSTACK-9772?page=3Dcom.atla= ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId= =3D16270371#comment-16270371 ]=20 ASF GitHub Bot commented on CLOUDSTACK-9772: -------------------------------------------- wido commented on issue #1934: [CLOUDSTACK-9772] Template: perform a HEAD r= equest to check file size from a URL URL: https://github.com/apache/cloudstack/pull/1934#issuecomment-347784289 =20 =20 Code LGTM =20 With one side-note though. I still see a lot of webservers not sending C= ontent-Length nor Content-Type (not used here) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Perform HEAD request to retrieve header information > --------------------------------------------------- > > Key: CLOUDSTACK-9772 > URL: https://issues.apache.org/jira/browse/CLOUDSTACK-977= 2 > Project: CloudStack > Issue Type: Improvement > Security Level: Public(Anyone can view this level - this is the defa= ult.)=20 > Components: Template > Affects Versions: 4.2.0, 4.2.1, 4.3.0, 4.4.0, 4.5.0, 4.3.1, 4.4.1, 4.4= .2, 4.4.3, 4.3.2, 4.5.1, 4.4.4, 4.5.2, 4.6.0, 4.6.1, 4.6.2, 4.7.0, 4.7.1, 4= .8.0, 4.9.0, 4.8.1.1, 4.9.0.1, 4.5.2.2 > Reporter: Marc-Aur=C3=A8le Brothier > Assignee: Marc-Aur=C3=A8le Brothier > > The function in UriUtils which perform a check for the template file size= of an arbitrary URL is sending a `GET` request to only retrieve the respon= se header. A `HEAD` is the correct way of retrieving such information from = the response header. > This was affecting the restart of a management server since all templates= were retrieved when receiving the startup command from the secondary stora= ge sysvm. -- This message was sent by Atlassian JIRA (v6.4.14#64029)