Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Thu, 23 Nov 2017 22:06:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.13020049.1478853119000.312124.1511474760243@Atlassian.JIRA>
In-Reply-To: <JIRA.13020049.1478853119000@Atlassian.JIRA>
References: <JIRA.13020049.1478853119000@Atlassian.JIRA> <JIRA.13020049.1478853119594@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CLOUDSTACK-9593) User data check is
 inconsistent with python
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Thu, 23 Nov 2017 22:06:06 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9593?page=3Dcom.atla=
ssian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=
=3D16264813#comment-16264813 ]=20

ASF GitHub Bot commented on CLOUDSTACK-9593:
--------------------------------------------

blueorangutan commented on issue #1760: CLOUDSTACK-9593: userdata: enforce =
data is a multiple of 4 characters
URL: https://github.com/apache/cloudstack/pull/1760#issuecomment-346702896
=20
=20
   Packaging result: =E2=9C=94centos6 =E2=9C=94centos7 =E2=9C=94debian. JID=
-1293

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
=20
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> User data check is inconsistent with python
> -------------------------------------------
>
>                 Key: CLOUDSTACK-9593
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-959=
3
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the defa=
ult.)=20
>    Affects Versions: 4.4.2, 4.4.3, 4.3.2, 4.5.1, 4.4.4, 4.5.2, 4.6.0, 4.6=
.1, 4.6.2, 4.7.0, 4.7.1, 4.8.0, 4.9.0
>            Reporter: Marc-Aur=C3=A8le Brothier
>            Assignee: Marc-Aur=C3=A8le Brothier
>
> The user data is validated through the Apache commons codec library, but =
this library does not check that the length is a multiple of 4 characters. =
The RFC does not require it either. But the python script in the virtual ro=
uter that loads the user data does check for the possible padding presence,=
 requiring the string to be a multiple of 4 characters.
> {code:python}
> >>> import base64
> >>> base64.b64decode('foo')
> Traceback (most recent call last):
>   File "<stdin>", line 1, in <module>
>   File "/usr/local/Cellar/python/2.7.12/Frameworks/Python.framework/Versi=
ons/2.7/lib/python2.7/base64.py", line 78, in b64decode
>     raise TypeError(msg)
> TypeError: Incorrect padding
> >>> base64.b64decode('foo=3D')
> '~\x8a'
> {code}
> Currently since the java check is less restrictive, the user data gets sa=
ved into the database but the VR script crashes when it receives this VM us=
er data. On a single VM it is not really a problem. The critical issue is w=
hen a VR is restarted. The invalid pythonic base64 string makes the vmdata.=
py script crashed, resulting in a VR not starting at all.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)