cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10160) KVM VirtIO-SCSI not defined properly in Libvirt XML
Date Tue, 28 Nov 2017 14:08:01 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268768#comment-16268768
] 

ASF subversion and git services commented on CLOUDSTACK-10160:
--------------------------------------------------------------

Commit fdf250906066e63fb89ee1ab62efc1b6f70b94c1 in cloudstack's branch refs/heads/debian9-systemvmtemplate
from [~widodh]
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=fdf2509 ]

CLOUDSTACK-10160: Fix typo in Libvirt XML definition for Virtio-SCSI (#2341)

* CLOUDSTACK-10160: Fix typo in Libvirt XML definition for Virtio-SCSI

The attribute for the XML element 'controller' should be 'model' and
not 'mode'.

Source: https://libvirt.org/formatdomain.html#elementsControllers

  A scsi controller has an optional attribute model, which is one of
  'auto', 'buslogic', 'ibmvscsi', 'lsilogic', 'lsisas1068', 'lsisas1078',
  'virtio-scsi' or 'vmpvscsi'.

In the current state a regular SCSI device is attached and not a Virtio-SCSI
device.

Signed-off-by: Wido den Hollander <wido@widodh.nl>

* CLOUDSTACK-10160: Add UnitTest for LibvirtVMDef.SCSIDef

To make sure the XML output string is correct

Signed-off-by: Wido den Hollander <wido@widodh.nl>


> KVM VirtIO-SCSI not defined properly in Libvirt XML
> ---------------------------------------------------
>
>                 Key: CLOUDSTACK-10160
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10160
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.10.0.0
>            Reporter: Wido den Hollander
>            Assignee: Wido den Hollander
>             Fix For: Future
>
>
> The XML for defining Virtio-SCSI has a typo:
> It defines:
> *<controller type='scsi' index='0' mode='virtio-scsi'>*
> But this should be
> *<controller type='scsi' index='0' model='virtio-scsi'/>*
> Sources:
> - https://libvirt.org/formatdomain.html#elementsControllers
> - https://www.redhat.com/archives/libvirt-users/2014-February/msg00011.html
> A scsi controller has an optional attribute model, which is one of 'auto', 'buslogic',
'ibmvscsi', 'lsilogic', 'lsisas1068', 'lsisas1078', 'virtio-scsi' or 'vmpvscsi'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message