cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10142) Non default nics don't use network rate from VM's service offering
Date Tue, 14 Nov 2017 11:11:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251242#comment-16251242
] 

Rohit Yadav commented on CLOUDSTACK-10142:
------------------------------------------

The fix will be remove the conditional and make the behaviour consistent using this:

diff --git a/server/src/com/cloud/network/NetworkModelImpl.java b/server/src/com/cloud/network/NetworkModelImpl.java
index f3e25e8695..99df38999d 100644
--- a/server/src/com/cloud/network/NetworkModelImpl.java
+++ b/server/src/com/cloud/network/NetworkModelImpl.java
@@ -1001,7 +1001,7 @@ public class NetworkModelImpl extends ManagerBase implements NetworkModel
{
         boolean isSystemVmNetwork = false;
         if (vm != null) {
             Nic nic = _nicDao.findByNtwkIdAndInstanceId(networkId, vmId);
-            if (vm.getType() == Type.User && nic != null && nic.isDefaultNic())
{
+            if (vm.getType() == Type.User && nic != null) {
                 isUserVmsDefaultNetwork = true;
             } else if (vm.getType() == Type.DomainRouter && ntwkOff != null &&
                 (ntwkOff.getTrafficType() == TrafficType.Public || ntwkOff.getTrafficType()
== TrafficType.Guest)) {


> Non default nics don't use network rate from VM's service offering
> ------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-10142
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10142
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Rohit Yadav
>            Assignee: Rohit Yadav
>             Fix For: Future
>
>
> Non-default nics of a VM in CloudStack don't pick network rate from VM's service offering,
but from the specific network's network offering.
> This is however documented as an accepted/known behaviour:
> http://docs.cloudstack.apache.org/projects/cloudstack-administration/en/latest/service_offerings.html#network-throttling



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message