cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10140) When template is created from snapshot template.properties are corrupted
Date Fri, 17 Nov 2017 16:47:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257203#comment-16257203
] 

ASF GitHub Bot commented on CLOUDSTACK-10140:
---------------------------------------------

bwsw commented on issue #2322: CLOUDSTACK-10140: Fix for when template is created from snapshot
template.properties are corrupted
URL: https://github.com/apache/cloudstack/pull/2322#issuecomment-345295039
 
 
   Hi, @rafaelweingartner 
   Basically, I started from this one:
   
   https://github.com/apache/cloudstack/pull/2320/files#diff-71901db20e3d4adb6711e69c1c1ca2ba
   
   it was found by @rhtyd and I fixed Id from 1 to actual code. I don't include it into PR
because master already includes it. Next I went to debugging and opened the issue (CLOUDSTACK-10140)
you saw in Jira.
   
   ```
   root@cs2-secstorage-nfs1:/secondary/template/tmpl/2/209# cat template.properties 
   uniquename=209-2-3accb15b-8647-356b-9791-9e2f1ec36b6b
   filename=bbab2601-050d-4c18-ae35-00f2ba44de28.qcow2
   size=3254517760
   qcow2.filename=bbab2601-050d-4c18-ae35-00f2ba44de28.qcow2
   qcow2.virtualsize=10737418240
   public=true
   id=1
   ```
   
   ID is fixed by code from 1st diff, but other information is incorrect including size (I
don't see it in my snippet but AFAIK "size" field was incorrect and included something like
UUID).
   
   Next, https://issues.apache.org/jira/secure/ViewProfile.jspa?name=weizhou user provided
the patch and everything started to work fine.
   
   I suppose that 
   
   ```
   long size = _storage.getSize(destFileFullPath);
   ``` 
   
   works incorrectly. 
   
   The actual fix works the next way:
   We write basic info on step one (first try block). Next, we configure format processor
(second try block), like for qcow:
   
   ```
   processor = new QCOW2Processor();
   ```
   
   which actually does the rest of things correctly.  
   
   I think if basic format is incorrect the processor code stumbles upon it and unable to
write the rest of the format. 
   
   Frankly speaking, I didn't dive into details and it's a shame but It takes a lot of time
to move across all the ACS code, because I'm not a "real" java developer. But this patch really
works. I patched the 4.10, compiled, deployed into Agent, recreated SSVM and templates started
to work properly. Basically, I recommend to consult Wei Zhou about his patch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> When template is created from snapshot template.properties are corrupted
> ------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-10140
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10140
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Secondary Storage
>    Affects Versions: 4.10.1.0
>            Reporter: Ivan Kudryavtsev
>            Priority: Critical
>
> 1.st is for downloaded template
> root@cs2-secstorage-nfs1:/secondary/template/tmpl/2/210# cat template.properties 
> #
> #Sun Nov 12 14:28:44 UTC 2017
> filename=5bf56664-4030-3047-a479-07494452907f.qcow2
> id=210
> qcow2.size=3254517760
> public=true
> uniquename=210-2-d985ccb6-a6cf-3c4e-9756-06dd4d856533
> qcow2.virtualsize=10737418240
> virtualsize=10737418240
> checksum=2d0d1133faf3766a76c328f774c421ca
> hvm=true
> description=aaa
> qcow2=true
> qcow2.filename=5bf56664-4030-3047-a479-07494452907f.qcow2
> size=3254517760
> 2.nd is for created from the snapshot
> Those snapshots are removed upon SSVM reload/recreation.
> root@cs2-secstorage-nfs1:/secondary/template/tmpl/2/209# cat template.properties 
> uniquename=209-2-3accb15b-8647-356b-9791-9e2f1ec36b6b
> filename=bbab2601-050d-4c18-ae35-00f2ba44de28.qcow2
> size=3254517760
> qcow2.filename=bbab2601-050d-4c18-ae35-00f2ba44de28.qcow2
> qcow2.virtualsize=10737418240
> public=true
> id=1



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message