cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10138) Load br_netfilter in security_group management script
Date Wed, 22 Nov 2017 08:24:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262136#comment-16262136
] 

ASF GitHub Bot commented on CLOUDSTACK-10138:
---------------------------------------------

bwsw commented on a change in pull request #2319: CLOUDSTACK-10138: Load br_netfilter in security_group
management script
URL: https://github.com/apache/cloudstack/pull/2319#discussion_r152493705
 
 

 ##########
 File path: scripts/vm/network/security_group.py
 ##########
 @@ -61,6 +64,15 @@ def execute(cmd):
     logging.debug(cmd)
     return bash("-c", cmd).stdout
 
+def load_kernel_module(module_name):
+    module_proc_file = "/proc/modules"
+    idx = execute("grep -E '^%s' %s | cut -f1 -d' '" % (module_name, module_proc_file)).find(module_name)
+    if idx == -1:
+        logging.debug("Module %s is absent. Load it." % (module_name))
+        execute("modprobe %s" % (module_name))
 
 Review comment:
   @rhtyd  Hi, please, take a look at #2321, I think the solution when module is installed
during dpkg install is better than this one and this PR should be declined.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Load br_netfilter in security_group management script
> -----------------------------------------------------
>
>                 Key: CLOUDSTACK-10138
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10138
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: cloudstack-agent
>    Affects Versions: 4.10.0.0
>         Environment: Ubuntu 14.04
>            Reporter: Ivan Kudryavtsev
>
> When setting 
> sysctl -w net.bridge.bridge-nf-call-arptables=1
> sysctl -w net.bridge.bridge-nf-call-iptables=1
> sysctl -w net.bridge.bridge-nf-call-ip6tables=1
> /usr/share/cloudstack-common/scripts/vm/network/security_group.py
> doesn't check that br_netfilter is load.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message