cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (CLOUDSTACK-10137) Re-installation fails for cloudstack-management
Date Fri, 10 Nov 2017 09:09:00 GMT


ASF GitHub Bot commented on CLOUDSTACK-10137:

rhtyd commented on a change in pull request #2316: CLOUDSTACK-10137: Only link log4j if not
already present

 File path: debian/cloudstack-management.postinst
 @@ -57,7 +57,9 @@ if [ "$1" = configure ]; then
     chgrp cloud ${CONFDIR}/${DBPROPS}
     chown -R cloud:cloud /var/log/cloudstack/management
-    ln -s ${CONFDIR}/log4j-cloud.xml ${CONFDIR}/log4j.xml
+    if [ ! -e "$CONFDIR/log4j.xml" ]; then
+        ln -s ${CONFDIR}/log4j-cloud.xml ${CONFDIR}/log4j.xml
 Review comment:
   @marcaurele perhaps we can fix it as `ln -sf`?

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Re-installation fails for cloudstack-management
> -----------------------------------------------
>                 Key: CLOUDSTACK-10137
>                 URL:
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Marc-Aurèle Brothier
>            Assignee: Marc-Aurèle Brothier
> If you try to reinstall the package (using --reinstall for example) and build another
version of it, the linking of {{log4j.xml}} will fail since the file already exists, and let
the package improperly installed.

This message was sent by Atlassian JIRA

View raw message