cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10132) Multiple Management Servers Support for agents
Date Tue, 14 Nov 2017 11:47:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251280#comment-16251280
] 

ASF GitHub Bot commented on CLOUDSTACK-10132:
---------------------------------------------

DaanHoogland commented on a change in pull request #2309: CLOUDSTACK-10132: Multiple Management
Servers Support for agents
URL: https://github.com/apache/cloudstack/pull/2309#discussion_r150810715
 
 

 ##########
 File path: agent/src/com/cloud/agent/IAgentShell.java
 ##########
 @@ -22,33 +22,64 @@
 import com.cloud.utils.backoff.BackoffAlgorithm;
 
 public interface IAgentShell {
-    public Map<String, Object> getCmdLineProperties();
+    Map<String, Object> getCmdLineProperties();
 
-    public Properties getProperties();
+    Properties getProperties();
 
-    public String getPersistentProperty(String prefix, String name);
+    String getPersistentProperty(String prefix, String name);
 
-    public void setPersistentProperty(String prefix, String name, String value);
+    void setPersistentProperty(String prefix, String name, String value);
 
-    public String getHost();
+    String getNextHost();
 
-    public String getPrivateIp();
+    String getPrivateIp();
 
-    public int getPort();
+    int getPort();
 
-    public int getWorkers();
+    int getWorkers();
 
-    public int getProxyPort();
+    int getProxyPort();
 
-    public String getGuid();
+    String getGuid();
 
-    public String getZone();
+    String getZone();
 
-    public String getPod();
+    String getPod();
 
-    public BackoffAlgorithm getBackoffAlgorithm();
+    BackoffAlgorithm getBackoffAlgorithm();
 
-    public int getPingRetries();
+    int getPingRetries();
 
-    public String getVersion();
+    String getVersion();
+
+    void setHosts(String hosts);
+
+    /**
+     * Resets host counter to start from the beginning
+     */
+    void resetHostCounter();
 
 Review comment:
   I do not feel consistency is an issue here as much as the comment not giving more information
than the methodname, so yes, please remove.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Multiple Management Servers Support for agents
> ----------------------------------------------
>
>                 Key: CLOUDSTACK-10132
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10132
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.11.0.0
>            Reporter: Nicolas Vazquez
>            Assignee: Nicolas Vazquez
>
> Multiple Management Servers Support for agents



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message