cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10129) Show instances attached to a network/VR via navigation from VRs->instances
Date Thu, 16 Nov 2017 11:22:01 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255146#comment-16255146
] 

ASF GitHub Bot commented on CLOUDSTACK-10129:
---------------------------------------------

rafaelweingartner commented on a change in pull request #2327: CLOUDSTACK-10129: Show account,
network info in VR list view
URL: https://github.com/apache/cloudstack/pull/2327#discussion_r151386526
 
 

 ##########
 File path: ui/scripts/system.js
 ##########
 @@ -29,9 +29,19 @@
     var mapRouterType = function (index, router) {
         var routerType = _l('label.menu.system');
 
-        if (router.projectid) routerType = _l('label.project');
-        if (router.vpcid) routerType = _l('label.vpc');
-        if ("isredundantrouter" in router && router.isredundantrouter) routerType
= routerType + " (" + router.redundantstate + ")";
+        if (router.projectid) {
+            routerType = _l('label.project');
+            router.account = router.project;
+        }
+
+        if (router.vpcid) {
+            routerType = _l('label.vpc');
+            router.guestnetworkname = router.vpcname;
+        }
+
+        if ("isredundantrouter" in router && router.isredundantrouter) {
 
 Review comment:
   I believe you can use directly `router.isredundantrouter` here without needing to check
if the property `isredundantrouter` exists in the object `router`; `undefined `is interpreted
as `false`.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Show instances attached to a network/VR via navigation from VRs->instances
> --------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-10129
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10129
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Rohit Yadav
>            Assignee: Rohit Yadav
>            Priority: Trivial
>             Fix For: 4.11.0.0
>
>
> Navigate to Infra->Vrs->select a VR->View instances should show instances belonging
to guest network id of the VR



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message