cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10108) ConfigKey based approach for reading 'ping' configuaration for Management Server
Date Mon, 20 Nov 2017 08:01:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16258917#comment-16258917
] 

ASF GitHub Bot commented on CLOUDSTACK-10108:
---------------------------------------------

rhtyd commented on a change in pull request #2292: CLOUDSTACK-10108:ConfigKey based approach
for reading 'ping' configua…
URL: https://github.com/apache/cloudstack/pull/2292#discussion_r151921261
 
 

 ##########
 File path: engine/schema/src/com/cloud/host/dao/HostDaoImpl.java
 ##########
 @@ -995,8 +994,8 @@ public boolean updateState(Status oldStatus, Event event, Status newStatus,
Host
             }
         }
         if (event.equals(Event.ManagementServerDown)) {
-            Float pingTimeout = NumbersUtil.parseFloat(_configDao.getValue("ping.timeout"),
2.5f);
-            Integer pingInterval = NumbersUtil.parseInt(_configDao.getValue("ping.interval"),
60);
+            float pingTimeout = (Float)_configDepot.get("ping.timeout").value();
 
 Review comment:
   This switches from using one provider to another that uses that same strategy, if you use
ConfigKey you won't have to specify the global setting name and handle the type-casting.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> ConfigKey based approach for reading 'ping' configuaration for Management Server
> --------------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-10108
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10108
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: mrunalini
>            Priority: Minor
>
> In CLOUDSTACK-9886, we are reading ping.interval and ping.timeout using configdao which
involves direct reading of DB. So, replace it with ConfigKey based approach



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message