cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10106) GPU/vGPU Support on VMWare
Date Tue, 28 Nov 2017 15:13:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16268882#comment-16268882
] 

ASF GitHub Bot commented on CLOUDSTACK-10106:
---------------------------------------------

rafaelweingartner commented on a change in pull request #2340: CLOUDSTACK-10106: GPU/vGPU
Support on VMWare
URL: https://github.com/apache/cloudstack/pull/2340#discussion_r153520500
 
 

 ##########
 File path: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
 ##########
 @@ -4766,6 +4848,31 @@ protected Answer execute(UnregisterNicCommand cmd) {
         }
     }
 
+    /**
+     * GetGPUStatsCommand is used to collect the GPU/vGPU details of all the
+     * GPU enabled hosts.
+     * Do Nothing.
+     * @param cmd
+     * @return Answer
+     */
+    protected Answer execute(final GetGPUStatsCommand cmd) {
+        final VmwareContext context = getServiceContext();
+        final VmwareHypervisorHost hyperHost = getHyperHost(context);
+        final HostMO hostMo = new HostMO(context, hyperHost.getMor());
+
+        HashMap<String, HashMap<String, VgpuTypesInfo>> groupDetails = new HashMap<String,
HashMap<String, VgpuTypesInfo>>();
+
+        try {
+            groupDetails = hostMo.getGPUGroupDetails();
 
 Review comment:
   Yes this one. Then, you could do directly inside the Try/catch:
   ` HashMap<String, HashMap<String, VgpuTypesInfo>> groupDetails = hostMo.getGPUGroupDetails()`
   
   This would avoid the creation of a hashmap at line 4863 that is subsequently just dropped
for the garbage collector.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> GPU/vGPU Support on VMWare
> --------------------------
>
>                 Key: CLOUDSTACK-10106
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10106
>             Project: CloudStack
>          Issue Type: New Feature
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: API, UI, VMware
>    Affects Versions: 4.11.0.0
>            Reporter: Nitin Kumar Maharana
>              Labels: VMWARE
>             Fix For: 4.11.0.0
>
>
> VMware has added support for NVIDIA GRID K1 and NVIDIA GRID K2 cards as well as NVIDIA
Tesla M6 and Tesla M60 cards. This feature allows CloudStack VMs on ESXi hosts to use the
GPU cards connected to it. Currently, it supports only NVIDIA GRID K1 and K2 cards for CloudStack
VMs.
> Feature Specification: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=74681765



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message