cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10105) Follow maven standard for all modules
Date Wed, 22 Nov 2017 12:26:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262429#comment-16262429
] 

ASF GitHub Bot commented on CLOUDSTACK-10105:
---------------------------------------------

marcaurele commented on issue #2283: CLOUDSTACK-10105: Maven standard
URL: https://github.com/apache/cloudstack/pull/2283#issuecomment-346335644
 
 
   @rhtyd My goal was to align all projects, all poms to follow one standard, a cleanup process
thing. Currently there are 3 types of project: the ones using the old structure, the ones
using the new, and some redefining their `<build>` section (most of the time with unnecessary
changes). Of course the build works, otherwise we would be in trouble. But I feel the project
deserves more cleanup and standardization on how things are done. Then the usual copy/paste
of code & configuration will be aligned too when creating new modules. Also the `pom`
files will be simpler with less customization at different places within the sub-module tree.
   
   I agree that the cherry-picking could be cumbersome, if lot of them should happen. It makes
me think that it should be merge (if agreed) as the first commit for the next LTS version.
This will lower the cherry-pick frictions on backporting fixes. I'm up for handling the effort
to backport commits colliding with this one.
   
   On the 150+ PR waiting to be merged, I don't see that number really getting to a low value
any time soon since the build and check process is pretty long. The rebasing of any of them
is trivial, the only exception to newly created file, which would show up as an error pretty
quickly since they should be used directly by the PR's code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Follow maven standard for all modules
> -------------------------------------
>
>                 Key: CLOUDSTACK-10105
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10105
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Marc-Aurèle Brothier
>            Assignee: Marc-Aurèle Brothier
>            Priority: Minor
>
> The goal is to remove the custom module layout used and follow maven standard structures
for all. This will remove one module. It's only a matter of moving files around to their correct
location.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message