cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10090) createPortForwardingRule api call accepts 'halt' as Protocol which Stops VR
Date Wed, 08 Nov 2017 04:56:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243379#comment-16243379
] 

ASF GitHub Bot commented on CLOUDSTACK-10090:
---------------------------------------------

rhtyd closed pull request #2273: CLOUDSTACK-10090:createPortForwardingRule api call accepts
'halt' as …
URL: https://github.com/apache/cloudstack/pull/2273
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/server/src/com/cloud/network/element/VirtualRouterElement.java b/server/src/com/cloud/network/element/VirtualRouterElement.java
index 01bded0eff2..9021999da3f 100644
--- a/server/src/com/cloud/network/element/VirtualRouterElement.java
+++ b/server/src/com/cloud/network/element/VirtualRouterElement.java
@@ -23,6 +23,8 @@
 import java.util.Set;
 
 import javax.inject.Inject;
+
+import com.cloud.utils.net.NetUtils;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.beans.factory.annotation.Qualifier;
 import com.cloud.network.router.NetworkHelper;
@@ -568,7 +570,10 @@ public static String getHAProxyStickinessCapability() {
         capabilities.put(Service.SourceNat, sourceNatCapabilities);
 
         capabilities.put(Service.StaticNat, null);
-        capabilities.put(Service.PortForwarding, null);
+
+        final Map<Capability, String> portForwardingCapabilities = new HashMap<Capability,
String>();
+        portForwardingCapabilities.put(Capability.SupportedProtocols, NetUtils.TCP_PROTO
+ "," + NetUtils.UDP_PROTO);
+        capabilities.put(Service.PortForwarding, portForwardingCapabilities);
 
         return capabilities;
     }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> createPortForwardingRule api call accepts 'halt' as Protocol which Stops VR 
> ----------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-10090
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10090
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: mrunalini
>
> When we run the createPortForwardingRule API with input as Protocol as halt the PF rule
is added however Halt is executed on VR. Hence the VR is stopped.
> Following entry added to Firewall_Rules table and VirtualRouter went to halt(stopped)
> mysql> select * from firewall_rules where id = 7 
> *************************** 1. row ***************************
> id: 7
> uuid: XXXXXXXXXXXXXXXXXXXXXXXXXXX
> ip_address_id: 13
> start_port: 222
> end_port: 222
> state: Revoke
> protocol: `halt`
> purpose: PortForwarding
> account_id: 2
> domain_id: 1
> network_id: 208
> xid: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
> created: 2017-09-04 04:48:16
> icmp_code: NULL
> icmp_type: NULL
> related: NULL
> type: User
> vpc_id: NULL
> traffic_type: NULL
> display: 1



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message