cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9880) Expansion of Management IP Range.
Date Wed, 08 Nov 2017 21:00:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244715#comment-16244715
] 

ASF GitHub Bot commented on CLOUDSTACK-9880:
--------------------------------------------

nitin-maharana commented on a change in pull request #2048: CLOUDSTACK-9880: Expansion of
Management IP Range.
URL: https://github.com/apache/cloudstack/pull/2048#discussion_r149794905
 
 

 ##########
 File path: api/src/org/apache/cloudstack/api/command/admin/network/CreateManagementNetworkIpRangeCmd.java
 ##########
 @@ -0,0 +1,140 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.admin.network;
+
+import org.apache.log4j.Logger;
+
+import org.apache.cloudstack.acl.RoleType;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseAsyncCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.PodResponse;
+
+import com.cloud.dc.Pod;
+import com.cloud.event.EventTypes;
+import com.cloud.exception.ConcurrentOperationException;
+import com.cloud.exception.InsufficientCapacityException;
+import com.cloud.exception.ResourceAllocationException;
+import com.cloud.exception.ResourceUnavailableException;
+import com.cloud.user.Account;
+
+@APICommand(name = "createManagementNetworkIpRange",
+        description = "Creates a Management network IP range.",
+        responseObject = PodResponse.class,
+        since = "4.10.0.0",
+        requestHasSensitiveInfo = false,
+        responseHasSensitiveInfo = false,
+        authorized = {RoleType.Admin})
+public class CreateManagementNetworkIpRangeCmd extends BaseAsyncCmd {
+    public static final Logger s_logger = Logger.getLogger(CreateManagementNetworkIpRangeCmd.class);
+
+    private static final String s_name = "createmanagementnetworkiprangeresponse";
 
 Review comment:
   @rhtyd, Thanks for reviewing the PR.
   Here, I don't find any difference except some extra parameters for the variables(authorized,
validations, acceptedOnAdminPort). Did you mean the same or something else.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Expansion of Management IP Range.
> ---------------------------------
>
>                 Key: CLOUDSTACK-9880
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9880
>             Project: CloudStack
>          Issue Type: New Feature
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: API
>    Affects Versions: 4.10.0.0
>            Reporter: Nitin Kumar Maharana
>             Fix For: 4.10.1.0
>
>
> At present, The management IP range can only be expanded under the same subnet. According
to existing range, either the last IP can be forward extended or the first IP can be backward
extended. But we cannot add an entirely different range from the same subnet. So the expansion
of range is subnet bound, which is fixed. But when the range gets exhausted and a user wants
to deploy more system VMs, then the operation would fail. The purpose of this feature is to
expand the range of management network IPs within the existing subnet. It can also delete
and list the IP ranges. 
> Please find the FS here : https://cwiki.apache.org/confluence/display/CLOUDSTACK/Expansion+of+Management+IP+Range



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message