cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9880) Expansion of Management IP Range.
Date Fri, 03 Nov 2017 15:14:01 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237726#comment-16237726
] 

ASF GitHub Bot commented on CLOUDSTACK-9880:
--------------------------------------------

rhtyd commented on a change in pull request #2048: CLOUDSTACK-9880: Expansion of Management
IP Range.
URL: https://github.com/apache/cloudstack/pull/2048#discussion_r148809330
 
 

 ##########
 File path: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
 ##########
 @@ -1097,8 +1095,243 @@ public void doInTransactionWithoutResult(final TransactionStatus
status) {
     }
 
     @Override
+    @DB
+    public Pod createPodIpRange(final CreateManagementNetworkIpRangeCmd cmd) {
+
+        //Check if calling account is root admin.
+        final Account account = CallContext.current().getCallingAccount();
+
+        if(!_accountMgr.isRootAdmin(account.getId())) {
+            throw new PermissionDeniedException("Cannot perform this operation, Calling account
is not root admin: " + account.getId());
+        }
+
+        final long podId = cmd.getPodId();
+        final String gateway = cmd.getGateWay();
+        final String netmask = cmd.getNetmask();
+        final String startIp = cmd.getStartIp();
+        String endIp = cmd.getEndIp();
+
+        final HostPodVO pod = _podDao.findById(podId);
+
+        if(pod == null) {
+            throw new InvalidParameterValueException("Unable to find pod by ID: " + podId);
+        }
+
+        final long zoneId = pod.getDataCenterId();
+
+        //Check if gateway is a valid IP address.
+        if(!NetUtils.isValidIp(gateway)) {
+            throw new InvalidParameterValueException("The gateway IP address is invalid.");
+        }
+
+        //Check if netmask is valid.
 
 Review comment:
   Remove comments, they tell what the code is trying to do (redundancy)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Expansion of Management IP Range.
> ---------------------------------
>
>                 Key: CLOUDSTACK-9880
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9880
>             Project: CloudStack
>          Issue Type: New Feature
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: API
>    Affects Versions: 4.10.0.0
>            Reporter: Nitin Kumar Maharana
>            Priority: Major
>             Fix For: 4.10.1.0
>
>
> At present, The management IP range can only be expanded under the same subnet. According
to existing range, either the last IP can be forward extended or the first IP can be backward
extended. But we cannot add an entirely different range from the same subnet. So the expansion
of range is subnet bound, which is fixed. But when the range gets exhausted and a user wants
to deploy more system VMs, then the operation would fail. The purpose of this feature is to
expand the range of management network IPs within the existing subnet. It can also delete
and list the IP ranges. 
> Please find the FS here : https://cwiki.apache.org/confluence/display/CLOUDSTACK/Expansion+of+Management+IP+Range



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message