Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Wed, 25 Oct 2017 05:35:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.13094361.1502668385000.53037.1508909700392@Atlassian.JIRA>
In-Reply-To: <JIRA.13094361.1502668385000@Atlassian.JIRA>
References: <JIRA.13094361.1502668385000@Atlassian.JIRA> <JIRA.13094361.1502668385926@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CLOUDSTACK-10047) DVSwitch improvements
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 25 Oct 2017 05:35:06 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218123#comment-16218123 ] 

ASF GitHub Bot commented on CLOUDSTACK-10047:
---------------------------------------------

rhtyd commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements
URL: https://github.com/apache/cloudstack/pull/2293#discussion_r146758494
 
 
 ##########
 File path: engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java
 ##########
 @@ -100,29 +103,43 @@ public void lockRange(long dcId, long physicalNetworkId, Integer start, Integer
     }
 
     @Override
-    public List<DataCenterVnetVO> findVnet(long dcId, String vnet) {
-        SearchCriteria<DataCenterVnetVO> sc = VnetDcSearch.create();
-        ;
-        sc.setParameters("dc", dcId);
-        sc.setParameters("vnet", vnet);
-        return listBy(sc);
-    }
-
-    @Override
     public int countZoneVlans(long dcId, boolean onlyCountAllocated) {
         SearchCriteria<Integer> sc = onlyCountAllocated ? countAllocatedZoneVlans.create() : countZoneVlans.create();
         sc.setParameters("dc", dcId);
         return customSearch(sc, null).get(0);
     }
 
-    @Override
-    public List<DataCenterVnetVO> findVnet(long dcId, long physicalNetworkId, String vnet) {
+    private List<DataCenterVnetVO> findOverlappingVnets(final long dcId, final Long physicalNetworkId, final String vnet) {
+        final List<Integer> searchVnets = UriUtils.expandVlanUri(vnet);
+        final List<DataCenterVnetVO> overlappingVnets = new ArrayList<>();
+        if (searchVnets == null || searchVnets.size() == 0) {
 
 Review comment:
   Thanks, fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> DVSwitch improvements
> ---------------------
>
>                 Key: CLOUDSTACK-10047
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10047
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Rohit Yadav
>            Assignee: Rohit Yadav
>             Fix For: Future, 4.11.0.0
>
>
> All vlan trunking and list of vlan id/range, along with security policy settings on dvswitches.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)