cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10122) Unrelated error message
Date Sat, 28 Oct 2017 21:15:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223739#comment-16223739
] 

ASF GitHub Bot commented on CLOUDSTACK-10122:
---------------------------------------------

rafaelweingartner commented on a change in pull request #2302: CLOUDSTACK-10122: Unrelated
error message
URL: https://github.com/apache/cloudstack/pull/2302#discussion_r147564657
 
 

 ##########
 File path: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
 ##########
 @@ -1423,7 +1423,7 @@ public void prepare(VirtualMachineProfile vm, DeployDestination dest)
throws Sto
                     }
                 }
                 catch (Throwable e){
-                    s_logger.debug("[NSX_PLUGIN_LOG] ERROR: " + e.getMessage());
 
 Review comment:
   @nvazquez thanks for the work!
   Sorry, but I have to ask, do we need this try/catch block?
   It seems that the code at 1413-1423 does not throw checked exceptions. Is there some kind
of runtime exception that might happen in between 1413-1423 that we want to "hide"/swallow?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Unrelated error message
> -----------------------
>
>                 Key: CLOUDSTACK-10122
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10122
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>    Affects Versions: 4.11.0.0
>            Reporter: Nicolas Vazquez
>            Assignee: Nicolas Vazquez
>
> Remove unrelated text "NSX_PLUGIN_LOG" from error message



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message