cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10109) Enable dedication of public IPs to SSVM and CPVM
Date Thu, 26 Oct 2017 03:25:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219900#comment-16219900
] 

ASF GitHub Bot commented on CLOUDSTACK-10109:
---------------------------------------------

nvazquez commented on a change in pull request #2295: CLOUDSTACK-10109: Enable dedication
of public IPs to SSVM and CPVM
URL: https://github.com/apache/cloudstack/pull/2295#discussion_r147038497
 
 

 ##########
 File path: server/src/com/cloud/api/ApiResponseHelper.java
 ##########
 @@ -735,13 +740,28 @@ public VlanIpRangeResponse createVlanIpRangeResponse(Class<? extends
VlanIpRange
                     vlanResponse.setPhysicalNetworkId(pnw.getUuid());
                 }
             }
+            vlanResponse.setForSystemVms(getIsForSystemVms(vlan.getId()));
             vlanResponse.setObjectName("vlan");
             return vlanResponse;
         } catch (InstantiationException | IllegalAccessException e) {
             throw new CloudRuntimeException("Failed to create Vlan IP Range response", e);
         }
     }
 
+    /**
+     * Return true if vlan IP range is dedicated for system vms (SSVM and CPVM), false if
not
+     * @param vlanId vlan id
+     * @return true if VLAN IP range is dedicated to system vms
+     */
+    private boolean getIsForSystemVms(long vlanId){
 
 Review comment:
   Done, thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Enable dedication of public IPs to SSVM and CPVM
> ------------------------------------------------
>
>                 Key: CLOUDSTACK-10109
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10109
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Nicolas Vazquez
>            Assignee: Nicolas Vazquez
>
> It is required to dedicate a public IP range for SSVM and CPVM in order to apply firewall
rules to control inbound access.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message