cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-10047) DVSwitch improvements
Date Wed, 25 Oct 2017 05:46:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218141#comment-16218141
] 

ASF GitHub Bot commented on CLOUDSTACK-10047:
---------------------------------------------

rhtyd commented on a change in pull request #2293: CLOUDSTACK-10047: DVSwitch fixes and improvements
URL: https://github.com/apache/cloudstack/pull/2293#discussion_r146759604
 
 

 ##########
 File path: vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java
 ##########
 @@ -501,12 +510,18 @@ public static void updatePortProfile(VmwareContext context, String
ethPortProfil
             // No doubt about this, depending on vid=null to avoid lots of code below
             vid = null;
         } else {
+            if (vlanId != null) {
+                vlanId = vlanId.replace("vlan://", "");
+            }
             networkName = composeCloudNetworkName(namePrefix, vlanId, secondaryvlanId, networkRateMbps,
physicalNetwork);
 
-            if (vlanId != null && !UNTAGGED_VLAN_NAME.equalsIgnoreCase(vlanId)) {
+            if (vlanId != null && !UNTAGGED_VLAN_NAME.equalsIgnoreCase(vlanId) &&
!vlanId.contains(",") && !vlanId.contains("-")) {
                 createGCTag = true;
                 vid = Integer.parseInt(vlanId);
             }
+            if (vlanId != null && (vlanId.contains(",") || vlanId.contains("-")))
{
 
 Review comment:
   Fixed, thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> DVSwitch improvements
> ---------------------
>
>                 Key: CLOUDSTACK-10047
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-10047
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Rohit Yadav
>            Assignee: Rohit Yadav
>             Fix For: Future, 4.11.0.0
>
>
> All vlan trunking and list of vlan id/range, along with security policy settings on dvswitches.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message