cloudstack-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CLOUDSTACK-9880) Expansion of Management IP Range.
Date Thu, 26 Oct 2017 07:09:00 GMT

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220064#comment-16220064
] 

ASF GitHub Bot commented on CLOUDSTACK-9880:
--------------------------------------------

DaanHoogland commented on a change in pull request #2048: CLOUDSTACK-9880: Expansion of Management
IP Range.
URL: https://github.com/apache/cloudstack/pull/2048#discussion_r147059958
 
 

 ##########
 File path: engine/schema/src/com/cloud/dc/dao/DataCenterIpAddressDao.java
 ##########
 @@ -45,8 +45,11 @@
 
     int countIPs(long dcId, boolean onlyCountAllocated);
 
+    int countIPs(String ipAddress, long podId, long dcId, boolean onlyCountAllocated);
 
 Review comment:
   actually it doesn't. It can be one method that acts based upon the presence of values in
the parameters. i.e. if there is no ip present it searches for ranges in pods/DCs and if an
ip is present (not null) it checks for allocation. If the behaviour is really distinct than
so should the name. In that case i suggest you rename it to isAllocatedInPodOrDc(), or maybe
countIpAddressUsage() or countIpAddressOccurance?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Expansion of Management IP Range.
> ---------------------------------
>
>                 Key: CLOUDSTACK-9880
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9880
>             Project: CloudStack
>          Issue Type: New Feature
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: API
>    Affects Versions: 4.10.0.0
>            Reporter: Nitin Kumar Maharana
>             Fix For: 4.10.1.0
>
>
> At present, The management IP range can only be expanded under the same subnet. According
to existing range, either the last IP can be forward extended or the first IP can be backward
extended. But we cannot add an entirely different range from the same subnet. So the expansion
of range is subnet bound, which is fixed. But when the range gets exhausted and a user wants
to deploy more system VMs, then the operation would fail. The purpose of this feature is to
expand the range of management network IPs within the existing subnet. It can also delete
and list the IP ranges. 
> Please find the FS here : https://cwiki.apache.org/confluence/display/CLOUDSTACK/Expansion+of+Management+IP+Range



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message