Mailing-List: contact issues-help@cloudstack.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cloudstack.apache.org
Date: Wed, 26 Jul 2017 13:19:00 +0000 (UTC)
From: "ASF subversion and git services (JIRA)" <jira@apache.org>
To: cloudstack-issues@incubator.apache.org
Message-ID: <JIRA.12771019.1422538491000.17776.1501075140423@Atlassian.JIRA>
In-Reply-To: <JIRA.12771019.1422538491000@Atlassian.JIRA>
References: <JIRA.12771019.1422538491000@Atlassian.JIRA> <JIRA.12771019.1422538491812@jira-lw-us.apache.org>
Subject: [jira] [Commented] (CLOUDSTACK-8186) setRemoved(null) does not work
 as expected
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 26 Jul 2017 13:19:07 -0000


    [ https://issues.apache.org/jira/browse/CLOUDSTACK-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16101656#comment-16101656 ] 

ASF subversion and git services commented on CLOUDSTACK-8186:
-------------------------------------------------------------

Commit 03aca885ae9ce53232d0ba3759d14737ba40f288 in cloudstack's branch refs/heads/4.10 from Wei Zhou
[ https://gitbox.apache.org/repos/asf?p=cloudstack.git;h=03aca88 ]

CLOUDSTACK-8186: make setRemoved to null possible


> setRemoved(null) does not work as expected
> ------------------------------------------
>
>                 Key: CLOUDSTACK-8186
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8186
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Wei Zhou
>            Assignee: Wei Zhou
>            Priority: Critical
>
> in cloudstack 4.5, there are two locations where set the removed field as null.
> [root@localhost cloudstack.git(4.5)]# grep -r "setRemoved(null)" *
> engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java:            tmpltZoneVO.setRemoved(null);
> framework/cluster/src/com/cloud/cluster/ClusterManagerImpl.java:                    mshost.setRemoved(null);
> As far as I think, the proposal is to clean the removed field in the database.
> However, it does not work as expected.
> The removed field will be set the current date.
> After investigating for a long time, I find it is because the following part in ./framework/db/src/com/cloud/utils/db/GenericDaoBase.java
>     @DB()
>     protected void prepareAttribute(final int j, final PreparedStatement pstmt, final Attribute attr, Object value) throws SQLException {
>         if (attr.is(Attribute.Flag.DaoGenerated) && value == null) {
>             value = generateValue(attr);
>             if (attr.field == null) {
>                 pstmt.setObject(j, value);
>                 return;
>             }
>         }
> ......
>     @DB()
>     protected Object generateValue(final Attribute attr) {
>         if (attr.is(Attribute.Flag.Created) || attr.is(Attribute.Flag.Removed)) {
>             return new Date();
> ......


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)